[uss_qualifier] Add ed318 test scenario#1438
Open
raphaelcere wants to merge 6 commits intointeruss:mainfrom
Open
[uss_qualifier] Add ed318 test scenario#1438raphaelcere wants to merge 6 commits intointeruss:mainfrom
raphaelcere wants to merge 6 commits intointeruss:mainfrom
Conversation
ed318 initial copy Initial structure for ed318 add ED-318 schema as ressource initial copy ED-318 ed318 initial copy Initial structure for ed318 first working test add data sample with error
mickmis
reviewed
May 5, 2026
Contributor
There was a problem hiding this comment.
Thanks for the submission. I have a few comments and in addition we would need the following to be done:
- CLA to sign
- rebase onto / merge latest main
- source differently the ed318 JSON schema
- use a sample test data file
- remove superfluous files
With those changes, this looks good to me.
Please let me know if you need some help on those items.
Comment on lines
+14
to
+17
| source_schema_ed318_geozones: | ||
| resource_type: resources.eurocae.ed318.source_schema.SourceSchema | ||
| specification: | ||
| url: file://./test_data/che/geoawareness/flattened_schema.json |
Contributor
There was a problem hiding this comment.
The ed318 schema should be somehow sourced in the repo (most likely through a submodule of the source-of-truth ed318 repo if that is possible) rather than a resource passed to the scenario.
| @@ -0,0 +1,22 @@ | |||
| from implicitdict import ImplicitDict | |||
| ) as check: | ||
| try: | ||
| validate(instance=data, schema=schema) | ||
| except ValueError as e: |
Contributor
There was a problem hiding this comment.
According to the jsonschema documentation, this throws a jsonschema.exceptions.ValidationError
…odel.py Co-authored-by: Mickaël Misbach <mickael@misba.ch>
Co-authored-by: Mickaël Misbach <mickael@misba.ch>
Co-authored-by: Mickaël Misbach <mickael@misba.ch>
…odel.md Co-authored-by: Mickaël Misbach <mickael@misba.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of ED-318 test with validation scheme