feat(docker): bake gouda.genesis.json; bump to gouda chains#105
feat(docker): bake gouda.genesis.json; bump to gouda chains#105rswanson wants to merge 2 commits into
Conversation
Stale
|
| Source | host.startTimestamp |
|---|---|
signet @ feat/gouda-image:.github/genesis/gouda.genesis.json |
1779051536 |
node-components @ feat/gouda-genesis:crates/genesis/src/gouda.genesis.json |
1765226348 ✓ |
signet-sdk @ feat/gouda-known-chain:chains/gouda.rs::HOST_START_TIMESTAMP |
1765226348 ✓ |
Impact: the documented CHAIN_NAME=gouda path is safe — it uses the embedded GOUDA_GENESIS_JSON from the binary, which was built against the fixed node-components rev 752fa4a. The trap is GenesisSpec::Custom reading from disk via ROLLUP_GENESIS_JSON_PATH=/network_configs/gouda.genesis.json (the baked file): that path hits the wrong slot-calc anchor. Anyone copying the baked file as a "reference" inherits the same bug.
Fix: re-mirror from node-components/crates/genesis/src/gouda.genesis.json, or drop the baking entirely if the embedded const is intended as the only source of truth.
…nesis.json signet-sidecar moves to fully crates.io-published versions: - init4-bin-base 0.21 -> 0.23.1 - signet-blobber / signet-host-rpc / signet-node / signet-node-config / signet-rpc 0.18.0 -> 0.19.0 Adds .github/genesis/gouda.genesis.json (mirrored from upstream node-components) and bakes it into all three Dockerfiles at /network_configs/gouda.genesis.json. signet/ and signet-exex/ unchanged: their reth and signet-host-reth deps remain git-only upstream (reth not published by paradigmxyz; signet-host-reth marked publish = false in node-components). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rswanson
force-pushed
the
feat/gouda-image
branch
from
0de3da6 to
37e52ef
Compare
…pstream Local mirror was at 1779051536 (gouda-on-host deploy time, never the slot-calc anchor); upstream node-components has 1765226348 (parmigiana host genesis anchor — gouda runs on parmigiana host). The mirror was added at 62c258b and never re-synced through three subsequent dep bumps. The embedded GOUDA_GENESIS_JSON in the binary is unaffected (built against fixed node-components rev 752fa4a). This only fixes the on-disk baked file used by GenesisSpec::Custom via ROLLUP_GENESIS_JSON_PATH. Diff vs node-components/crates/genesis/src/gouda.genesis.json @ 752fa4a is now empty. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Fixed in 47f1ead. Diff vs |
Fraser999
left a comment
Fraser999
left a comment
There was a problem hiding this comment.
Should we include a patch-level version bump on each of the three binaries? (there are no backwards-incompatible env var changes afaik).
Otherwise this LGTM.
3 participants
Changes
init4-bin-base0.21 → 0.23.1signet-blobber,signet-host-rpc,signet-node,signet-node-config,signet-rpc0.18.0 → 0.19.0.github/genesis/gouda.genesis.json(mirrored from upstream node-components) and bake it into all three Dockerfiles at/network_configs/gouda.genesis.json, matching the existing parmigiana pattern.Verification
cargo +nightly fmt --checkcargo clippy --workspace --all-targets -- -D warningsRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-depscargo test -p signet-sidecar