refactor: extract shared telemetron sidecar installer

[royosherove]

Moves ~230 lines of duplicated telemetron logic from openclaw and roundhouse packs into packs/common-telemetron.sh.

Each pack now calls:

source "${SCRIPT_DIR}/../common-telemetron.sh"
install_telemetron <mode>

Changes:

• New packs/common-telemetron.sh — single install_telemetron <mode> public API
• packs/openclaw/install.sh — removed 104 lines of inline telemetron code
• packs/roundhouse/install.sh — removed 124 lines of inline telemetron code

Design:

• Uses telemetron detect (not legacy env vars) — auto-discovers by install dir
• sudo preserves SUDO_USER so telemetron resolves correct home dir
• Subshell isolation: never fails the caller
• curl --retry 3 for network resilience

[chatgpt-codex-connector]

💡 Codex Review

lowkey/packs/openclaw/install.sh

Lines 255 to 256 in eed963c

	source "${SCRIPT_DIR}/../common-telemetron.sh"
	install_telemetron openclaw

Keep OpenClaw test contract when extracting telemetron logic

This refactor removes should_run_telemetron() from packs/openclaw/install.sh, but packs/openclaw/test.sh still extracts that function from this file and now fails with could not extract should_run_telemetron (repro: bash packs/openclaw/test.sh). That makes the existing OpenClaw pack validation fail after this commit, so the refactor should either update the test harness to source common-telemetron.sh or preserve a compatibility wrapper in install.sh.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

lowkey/packs/common-telemetron.sh

Line 166 in 31365c4

timeout 30 sudo "$bin" detect \

Make telemetron sudo invocation non-interactive

The new shared installer calls sudo directly for telemetron detect without -n or a prior non-interactive capability check. In environments where sudo requires a password (or no controlling TTY is available), this can block until the timeout and may still prompt on /dev/tty, which breaks the sidecar contract of being silent and best-effort after pack success. The previous path used a sudo -n true gate before attempting privileged execution, so this introduces a user-visible regression on non-passwordless setups.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

💡 Codex Review

lowkey/packs/common-telemetron.sh

Lines 166 to 170 in d3a878e

	timeout 30 sudo "$bin" detect \
	--endpoint "$_TELEMETRON_ENDPOINT" \
	--enroll-endpoint "$_TELEMETRON_ENROLL_ENDPOINT" \
	--mode "$mode" \
	--force >>"$log" 2>&1 || {

Avoid interactive sudo in optional telemetron flow

Calling sudo unconditionally in install_telemetron can block installs in environments without passwordless sudo (for example, when a user has sudo access but must enter a password), which makes this best-effort sidecar stall for up to the timeout window after the pack reports success. In the previous openclaw path, sudo execution was gated by a non-interactive check, so this introduces a regression in install latency and UX for non-NOPASSWD setups.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".