feat(roundhouse): add telemetron sidecar using detect command#47
feat(roundhouse): add telemetron sidecar using detect command#47royosherove merged 1 commit intomainfrom
Conversation
Uses `telemetron detect --mode roundhouse --force` instead of the legacy TELEMETRON_MODE/SESSION_DIR env var approach. This auto-discovers roundhouse sessions and configures the secondary telemetron instance. - Install telemetron binary (no-env = binary-only install) - Run `telemetron detect` for auto-discovery + enrollment - Tier detection (same 3-method approach as openclaw pack) - --skip-telemetron flag + pack config support - Silent/bounded/fire-and-forget (never blocks main install)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4012ff2f35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ( | ||
| set +e | ||
| _telemetron_sidecar | ||
| ) || true |
There was a problem hiding this comment.
_telemetron_sidecar runs synchronously before write_done_marker, so a healthy Roundhouse install is not marked complete until all sidecar work finishes. In the slow/failure path this adds bounded but real delay (timeout 60 for install plus timeout 30 for detect, plus AWS probe timeouts), which contradicts the “never blocks main install” behavior documented in this script and can delay completion signaling for callers that wait on the marker.
Useful? React with 👍 / 👎.
| timeout 60 bash -c " | ||
| set -euo pipefail | ||
| curl --connect-timeout $connect_to --max-time $max_to -fsSL '$install_url' | bash | ||
| " || { |
There was a problem hiding this comment.
The initial telemetron bootstrap (curl ... | bash) is executed without stdout/stderr redirection, so on first-time installs (when telemetron is missing) installer output can leak to the user terminal. This breaks the local contract in this section that sidecar execution is silent and logs exclusively to $INSTALL_LOG.
Useful? React with 👍 / 👎.
Follow-up to 3b71714 \u2014 the previous commit covered P2a (done marker) but the P2b edit for redirecting the first-install bootstrap output didn't land. Append '>>$log 2>&1' to the 'timeout 60 bash -c ...' wrapper so the section's silent-only contract also holds on fresh hosts where telemetron is missing. Addresses the second half of Codex review on PR #47.
|
Triage of Codex review 4233777196 (PR already merged \u2014 addressed in follow-up #48): P2 \u2014 done marker blocked by sidecar: AGREE, FIXED in 3b71714. P2 \u2014 telemetron curl|bash bootstrap leaked to terminal: AGREE, FIXED in 1c68e56. |
1 participant
Uses
telemetron detect --mode roundhouse --forceinstead of the legacy TELEMETRON_MODE/SESSION_DIR env var approach. Auto-discovers roundhouse sessions and configures the secondary telemetron instance.telemetron detectfor auto-discovery + enrollment--skip-telemetronflag + pack config supportRequires telemetron v0.5.0+ (detect command).