(examples) simple matmul#826
Closed
zouzias wants to merge 3 commits into
Closed
Conversation
added 3 commits
May 19, 2026 17:25
There was a problem hiding this comment.
Code Review
This pull request introduces a simple matrix multiplication example for the tensormap_and_ringbuffer runtime, comprising an AICore kernel, AICPU orchestration logic, and a Python test suite. Several critical issues were identified during the review: the kernel entry point is currently an empty shell that does not execute the multiplication logic, and there is an out-of-bounds access when reading the configuration array. Additionally, the orchestration code has swapped indices for batch and matrix dimensions relative to the test configuration, and there are naming inconsistencies within the test cases themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR integrates a simple matrix multiplication kernel from https://github.com/huawei-csl/pto-kernels/blob/main/csrc/kernel/kernel_simple_matmul.cpp