Skip to content

(examples) simple matmul#826

Closed
zouzias wants to merge 3 commits into
hw-native-sys:mainfrom
zouzias:anastasios_simple_matmul
Closed

(examples) simple matmul#826
zouzias wants to merge 3 commits into
hw-native-sys:mainfrom
zouzias:anastasios_simple_matmul

Conversation

@zouzias
Copy link
Copy Markdown
Contributor

@zouzias zouzias commented May 20, 2026

This MR integrates a simple matrix multiplication kernel from https://github.com/huawei-csl/pto-kernels/blob/main/csrc/kernel/kernel_simple_matmul.cpp

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a simple matrix multiplication example for the tensormap_and_ringbuffer runtime, comprising an AICore kernel, AICPU orchestration logic, and a Python test suite. Several critical issues were identified during the review: the kernel entry point is currently an empty shell that does not execute the multiplication logic, and there is an out-of-bounds access when reading the configuration array. Additionally, the orchestration code has swapped indices for batch and matrix dimensions relative to the test configuration, and there are naming inconsistencies within the test cases themselves.

@zouzias zouzias closed this May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant