Add streaming extractor#9
Conversation
| "strict": true, | ||
| "noImplicitAny": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "node", |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| default as Meyda | ||
| } from "meyda"; | ||
| import { Observable, from, of } from "rxjs"; | ||
| import { take, bufferCount, map, tap } from "rxjs/operators"; |
There was a problem hiding this comment.
This file should be it's own commit, and subsequent commits should maybe have one implementation that's observable compatible. I think the observable implementation is more concise and clearer regardless.
There was a problem hiding this comment.
To clarify: It might be good to remove the original implementation, and have the original two feature extractors use the observable based implementation. First would have to make the observable implementation handle hopping windows (negative and positive offsets). Maybe a separate PR, this could go in a GH issue.
There was a problem hiding this comment.
Then again, it might not, since the inline worker would now have rxjs code in it even if it's not strictly needed, and would increase the bundle size. To do: figure out how much it would increase the bundle size.
| ); | ||
| } | ||
|
|
||
| export function extractFeatureObservable({ |
There was a problem hiding this comment.
Should there be a separate implementation of this library that does observable? Maybe...
There was a problem hiding this comment.
The thinking here was that rxjs might bump the bundle size too much to be acceptable for a use case where you don't need streaming.
| const [buffers, features, extractionParameters, internalParameters] = data; | ||
|
|
||
| postMessage(await extractFeatures(buffers, features, extractionParameters)); | ||
| const batchSize = internalParameters.batchSize || buffers.length; |
There was a problem hiding this comment.
This PR isn't mergeable until this breaking change disappears.
There was a problem hiding this comment.
I've forgotten exactly why this is a breaking change, the tests pass. The tests probably aren't good enough.
There was a problem hiding this comment.
Also, we're in alpha, we don't care about no stinkin breaking changes!
hughrawlinson
force-pushed
the
add-streaming-extractor
branch
from
7826709 to
639a242
Compare
hughrawlinson
force-pushed
the
add-streaming-extractor
branch
from
639a242 to
09a33c8
Compare
1 participant
No description provided.