re-enable all disabled warnings in CMake#9092
Open
alexreinking wants to merge 12 commits intomainfrom
Open
Conversation
Member
Author
|
Fixing all the int64-to-int32 warnings is likely quixotic, but I think they're still worth some level of evaluation... the code in HexagonAlignment.h (for example) was really gnarly and the warning was actually a good hint that more thought needed to be put into that routine. |
abadams
reviewed
Apr 13, 2026
src/HexagonAlignment.h
Outdated
| int native_lanes = required_alignment / op->value.type().bytes(); | ||
| return is_aligned_impl<Store>(op, native_lanes, aligned_offset); | ||
| bool known_alignment = (op->alignment.modulus % native_lanes) == 0; | ||
| int64_t remainder = op->alignment.remainder % native_lanes; |
Member
There was a problem hiding this comment.
If op->alignment is a negative constant (seems impossible?) % will do the wrong thing here. Should use mod_imp instead.
abadams
reviewed
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen some drift in the warnings checked by CI between Make/CMake. I'm going to try re-enabling all warnings just to see what we still need to disable.