Skip to content

feat: allow sending message with client/basic path#964

Open
jmattheis wants to merge 1 commit into
masterfrom
appid
Open

feat: allow sending message with client/basic path#964
jmattheis wants to merge 1 commit into
masterfrom
appid

Conversation

@jmattheis
Copy link
Copy Markdown
Member

This PR removes the need for using application tokens for sending messages. This would allow us to hash our tokens as described in #325.

@jmattheis jmattheis requested a review from a team as a code owner May 25, 2026 16:34
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.46%. Comparing base (a309216) to head (be50976).

Files with missing lines Patch % Lines
api/message.go 84.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   74.41%   74.46%   +0.05%     
==========================================
  Files          62       62              
  Lines        2994     3008      +14     
==========================================
+ Hits         2228     2240      +12     
- Misses        604      605       +1     
- Partials      162      163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eternal-flame-AD
Copy link
Copy Markdown
Member

It's too late where I am right now but I will try it out tomorrow. It looks good to me, are you committed to using hashed tokens? I can update the previous hashed token PR on top of this so we can get this feature done.

@jmattheis
Copy link
Copy Markdown
Member Author

Yeah, but let's do this the token hashing in a separate PR, as it probably needs a little more discussion.

I'd say we make the token hashing backwards compatible, so that we add a new token_hashed column (or do it via a different token format) which is filled for newly created client/apps/plugins while the old tokens continue to work without any database migration. If we define a new token format we could check when authenticating which column to check against.

The new token format could look like gtfya_ID_SECRET (GoTiFY App). We then parse ID, and then hash SECRET and compare it against the database value.

But let's discuss this in a different PR/ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants