Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #964 +/- ##
==========================================
+ Coverage 74.41% 74.46% +0.05%
==========================================
Files 62 62
Lines 2994 3008 +14
==========================================
+ Hits 2228 2240 +12
- Misses 604 605 +1
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It's too late where I am right now but I will try it out tomorrow. It looks good to me, are you committed to using hashed tokens? I can update the previous hashed token PR on top of this so we can get this feature done. |
|
Yeah, but let's do this the token hashing in a separate PR, as it probably needs a little more discussion. I'd say we make the token hashing backwards compatible, so that we add a new token_hashed column (or do it via a different token format) which is filled for newly created client/apps/plugins while the old tokens continue to work without any database migration. If we define a new token format we could check when authenticating which column to check against. The new token format could look like gtfya_ID_SECRET (GoTiFY App). We then parse ID, and then hash SECRET and compare it against the database value. But let's discuss this in a different PR/ticket. |
This PR removes the need for using application tokens for sending messages. This would allow us to hash our tokens as described in #325.