Skip to content

remove non-target entries leaking into DawnTargets.cmake#63

Open
domibel wants to merge 1 commit intogoogle:mainfrom
domibel:fix/cmake-install-partition-alloc
Open

remove non-target entries leaking into DawnTargets.cmake#63
domibel wants to merge 1 commit intogoogle:mainfrom
domibel:fix/cmake-install-partition-alloc

Conversation

@domibel
Copy link
Copy Markdown
Contributor

@domibel domibel commented Apr 10, 2026

I am using find_package(Dawn REQUIRED) and got:

CMake Error: The link interface of target "dawn::webgpu_dawn" contains:
  dawn::partition_alloc
but the target was not found.

DawnTargets.cmake incorrectly includes dawn::partition_alloc
since commit 96e9e61 as part of webgpu_dawn's link interface:

set_target_properties(dawn::webgpu_dawn PROPERTIES
  INTERFACE_LINK_LIBRARIES "...;dawn::partition_alloc;...")

dawn::partition_alloc is a header-only internal target that is never
installed, so any downstream find_package(Dawn) fails.

@github-actions
Copy link
Copy Markdown

👋 Thanks for your contribution! Your PR has been imported to Gerrit.
Please visit https://dawn-review.googlesource.com/c/dawn/+/302075 to see it and CC yourself on the change.
After iterating on feedback, please comment on the Gerrit review to notify reviewers.
All reviews are handled within Gerrit, any comments on the GitHub PR may be missed.
You can continue to upload commits to this PR, and they will be automatically imported
into Gerrit.

@kainino0x
Copy link
Copy Markdown
Member

@meuter you added this code in #60, does this change break things for you?

@meuter
Copy link
Copy Markdown
Contributor

meuter commented Apr 11, 2026

Hi @kainino0x, I just double checked and the Android monolithic build is still working even with the patch in this PR. liblog is collected in the other loop here . I guess I was a little too eager when collecting dependencies. I assumed wrongly from this comment that those were public interface targets.

are there any public interface (header only) targets that could be missed with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants