Add chromium_test_compat_main function#62
Conversation
Implement main function for Chromium test compatibility
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
kainino0x
left a comment
There was a problem hiding this comment.
Hi, please explain the purpose of this change. I don't know why it's needed.
|
Well it was a test but this change adds a Chromium-compatible test entry point. It just allows the Chromium test harness to override execution when needed, while still falling back to normal GoogleTest execution otherwise. This ensures tests run correctly both inside Chromium and in standalone environments. I don't think it is necessary though |
|
Does something in Chromium automatically pick up this file path or does it require additional build file changes (that aren't included here) to use it? I don't want to add a file that's unused or appears to be unused. |
|
oh yea you're right I forgot nothing in Chromium automatically picks up this file path. It would require corresponding BUILD.gn changes to be compiled and used I won't add this in the build.gn as I don't think it is necessary right now sorry for the PR |
Implement main function for Chromium test compatibility