Skip to content

fix: replace bare except with except Exception#4949

Open
YouFoxGirl wants to merge 1 commit intogoogle:mainfrom
YouFoxGirl:foxclaw/fix-2026-03-21T23-18-37
Open

fix: replace bare except with except Exception#4949
YouFoxGirl wants to merge 1 commit intogoogle:mainfrom
YouFoxGirl:foxclaw/fix-2026-03-21T23-18-37

Conversation

@YouFoxGirl
Copy link

@YouFoxGirl YouFoxGirl commented Mar 22, 2026

What this PR does

Replace bare except: clauses with except Exception: to avoid catching
KeyboardInterrupt and SystemExit. Added a TODO note for future
more specific exception handling where applicable.

Why this matters

Bare except: catches all exceptions including KeyboardInterrupt
and SystemExit, which can hide bugs and make debugging harder.

@google-cla
Copy link

google-cla bot commented Mar 22, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Use except Exception: instead of bare except: in the live agent API
sample.
@YouFoxGirl YouFoxGirl force-pushed the foxclaw/fix-2026-03-21T23-18-37 branch from e0395af to 3bb383b Compare March 22, 2026 02:31
@adk-bot
Copy link
Collaborator

adk-bot commented Mar 22, 2026

Response from ADK Triaging Agent

Hello @YouFoxGirl, thank you for creating this PR!

To help reviewers evaluate your contribution, could you please provide a "testing plan" section in your PR description explaining how you've tested these changes?

Also, for bug fixes, we require an associated GitHub issue. If one doesn't exist, could you please create one and link it to this PR?

This information will help us review your PR more efficiently. Thanks!

@adk-bot adk-bot added the live [Component] This issue is related to live, voice and video chat label Mar 22, 2026
@rohityan rohityan self-assigned this Mar 23, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label Mar 23, 2026
@rohityan
Copy link
Collaborator

Hi @YouFoxGirl , Thank you for your contribution! It appears you haven't yet signed the Contributor License Agreement (CLA). Please visit https://cla.developers.google.com/ to complete the signing process. Once the CLA is signed, we'll be able to proceed with the review of your PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

live [Component] This issue is related to live, voice and video chat request clarification [Status] The maintainer need clarification or more information from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants