Skip to content

Rizzcharts kotlin#1014

Merged
jgindin merged 5 commits intogoogle:mainfrom
jgindin:rizzcharts-kotlin
Apr 14, 2026
Merged

Rizzcharts kotlin#1014
jgindin merged 5 commits intogoogle:mainfrom
jgindin:rizzcharts-kotlin

Conversation

@jgindin
Copy link
Copy Markdown
Collaborator

@jgindin jgindin commented Mar 27, 2026

Description

New Kotlin version of the rizzcharts sample using the Kotlin version of the A2UI SDK.

Pre-launch Checklist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Kotlin SDK for A2UI, providing core utilities for schema management, validation, and A2A protocol handling, along with a Kotlin implementation of the Rizzcharts sample agent. The review identifies a critical Kotlin version mismatch between the SDK and the sample project that causes build failures. Additionally, the agent's system prompt configuration incorrectly excludes the A2UI schema and examples, which are necessary for generating valid payloads. Further improvements suggested include using stable raw URLs for schema references and adding logging for JSON parsing failures in the A2A handler to improve debuggability.

Comment thread agent_sdks/kotlin/build.gradle.kts
Comment thread samples/agent/adk/rizzcharts/kotlin/build.gradle.kts Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/a2a/A2aHandler.kt Outdated
Comment thread agent_sdks/kotlin/src/main/kotlin/com/google/a2ui/a2a/A2aHandler.kt Outdated
@jgindin jgindin force-pushed the rizzcharts-kotlin branch from a3a64de to 1ebd6d5 Compare March 27, 2026 21:58
@jgindin jgindin requested a review from dmandar March 30, 2026 13:18
@jgindin jgindin force-pushed the rizzcharts-kotlin branch from 1ebd6d5 to 231e779 Compare April 13, 2026 22:03
@jgindin jgindin requested a review from jacobsimionato April 14, 2026 15:17
@jgindin jgindin requested a review from jonsharkey April 14, 2026 16:39
@jgindin jgindin merged commit d20e197 into google:main Apr 14, 2026
12 checks passed
@jgindin jgindin deleted the rizzcharts-kotlin branch April 14, 2026 16:59
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants