Skip to content

fix exception handling #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gms1 merged 1 commit into from
Mar 28, 2026
Merged

fix exception handling #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,10 @@
"targets": [
{
"target_name": "<(module_name)",
"cflags!": [ "-fno-exceptions" ],
"cflags_cc!": [ "-fno-exceptions" ],
"xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
"xcode_settings": {
"CLANG_CXX_LIBRARY": "libc++",
"MACOSX_DEPLOYMENT_TARGET": "10.7",
},
"msvs_settings": {
"VCCLCompilerTool": { "ExceptionHandling": 1 },
},
"include_dirs": [
"<!@(node -p \"require('node-addon-api').include\")"],
"conditions": [
Expand All @@ -40,7 +35,7 @@
},
{
"dependencies": [
"<!(node -p \"require('node-addon-api').gyp\")",
"<!(node -p \"require('node-addon-api').targets\"):node_addon_api_except",
"deps/sqlite3.gyp:sqlite3"
]
}
Expand All @@ -52,7 +47,7 @@
"src/node_sqlite3.cc",
"src/statement.cc"
],
"defines": [ "NAPI_VERSION=<(napi_build_version)", "NAPI_DISABLE_CPP_EXCEPTIONS=1" ]
"defines": [ "NAPI_VERSION=<(napi_build_version)" ]
}
]
}
6 changes: 5 additions & 1 deletion docs/DEVELOP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ This project uses [npm version](https://docs.npmjs.com/cli/v10/commands/npm-vers
- Upload them as release assets
- Publish the package to npm

3. ** Create GitHub Release from tag
3. ** Edit the generated Pre-release
- select "Generate release notes"
- uncheck "Set as pre-release"
- check "Set as latest release" if it is
- click "Update Releasse

### Version format

Expand Down
Loading