fix(scripts): honor PowerShell agent and script filters#1969
Open
chenry-me wants to merge 1 commit intogithub:mainfrom
Open
fix(scripts): honor PowerShell agent and script filters#1969chenry-me wants to merge 1 commit intogithub:mainfrom
chenry-me wants to merge 1 commit intogithub:mainfrom
Conversation
Rename the Normalize-List parameter in create-release-packages.ps1 to avoid conflicting with PowerShell's automatic $input variable. This fixes Windows offline scaffolding when -Agents and -Scripts are passed. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Windows offline scaffolding bug in the PowerShell release-packaging script where -Agents/-Scripts filters were silently ignored due to a parameter name collision with PowerShell’s automatic $input variable.
Changes:
- Rename
Normalize-Listparameter from$Inputto$Valueto avoid$inputcollision. - Update the
Normalize-Listcall sites so agent/script filtering is honored.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1946
Description
Fixes a Windows offline scaffolding bug in
create-release-packages.ps1.The PowerShell helper
Normalize-Listused$Inputas its parameter name, which conflicts with PowerShell's automatic$inputvariable. This caused-Agentsand-Scriptsfiltering to be ignored, sospecify init --offlinecould fail withrelease script produced no output.This change renames the parameter and updates the call sites so the selected agent/script filters are honored correctly.
Testing
uv run specify --helpuv sync && uv run pytestManual verification:
specify init ... --offline --ai opencode --script psbefore the fixNote:
zipfor the bash release-packaging path and tests that pass Windows absolute paths directly to bash.AI Disclosure
I used OpenCode (GPT-5.4) to help analyze the code, identify the root cause, and draft parts of the fix description (to help me communicate more clearly in English). I manually reproduced the bug, reviewed the relevant script behavior, and verified the final fix locally.