Skip to content

fix: add authorAssociation to IssueFragment (GraphQL path) #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lanxevo3 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

fix: add authorAssociation to IssueFragment (GraphQL path) #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/github/issues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ type IssueFragment struct {
DatabaseID int64

Author struct {
Login githubv4.String
Login githubv4.String
Association githubv4.String
}
CreatedAt githubv4.DateTime
UpdatedAt githubv4.DateTime
Expand Down
15 changes: 8 additions & 7 deletions pkg/github/minimal_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,16 +387,17 @@ func convertToMinimalIssue(issue *github.Issue) MinimalIssue {

func fragmentToMinimalIssue(fragment IssueFragment) MinimalIssue {
m := MinimalIssue{
Number: int(fragment.Number),
Title: sanitize.Sanitize(string(fragment.Title)),
Body: sanitize.Sanitize(string(fragment.Body)),
State: string(fragment.State),
Comments: int(fragment.Comments.TotalCount),
CreatedAt: fragment.CreatedAt.Format(time.RFC3339),
UpdatedAt: fragment.UpdatedAt.Format(time.RFC3339),
Number: int(fragment.Number),
Title: sanitize.Sanitize(string(fragment.Title)),
Body: sanitize.Sanitize(string(fragment.Body)),
State: string(fragment.State),
Comments: int(fragment.Comments.TotalCount),
CreatedAt: fragment.CreatedAt.Format(time.RFC3339),
UpdatedAt: fragment.UpdatedAt.Format(time.RFC3339),
User: &MinimalUser{
Login: string(fragment.Author.Login),
},
AuthorAssociation: string(fragment.Author.Association),
}

for _, label := range fragment.Labels.Nodes {
Expand Down