Skip to content

Go: fix bad join order #21576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Go: fix bad join order #21576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be7265
Go: fix bad join order
owen-mc Mar 25, 2026
a1caae8
Change pragma
owen-mc Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/ql/lib/semmle/go/DiagnosticsReporting.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ private class Diagnostic extends @diagnostic {
string getMessage() { diagnostics(this, _, _, result, _, _) }

/** Gets the file that this error is associated with, if any. */
File getFile() { result = this.getLocation().getFile() }
File getFile() { result = pragma[only_bind_out](this.getLocation()).getFile() }

/** Gets the location for this error. */
Location getLocation() { diagnostics(this, _, _, _, _, result) }
Expand Down
Loading