Open
Conversation
Add `DOTNET_CLI_TELEMETRY_OPTOUT=1` to the minimal environment used for all `dotnet` invocations. The telemetry is unnecessary and may even be causing segfaults in some cases.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an additional environment variable to the centralized “minimal environment” used for running dotnet in the C# dependency fetching/extractor tooling, opting out of .NET CLI telemetry.
Changes:
- Extend
IDotNetCliInvoker.MinimalEnvironmentto includeDOTNET_CLI_TELEMETRY_OPTOUT=1. - Update the associated XML documentation to describe the new variable.
| /// DOTNET_CLI_UI_LANGUAGE: The .NET CLI language is set to English to avoid localized output. | ||
| /// MSBUILDDISABLENODEREUSE: To ensure clean environment for each build. | ||
| /// DOTNET_SKIP_FIRST_TIME_EXPERIENCE: To skip first time experience messages. | ||
| /// DOTNET_CLI_TELEMETRY_OPTOUT: To skip any dotnet telemetry: it's unnecessary and can even cause issues. |
There was a problem hiding this comment.
Doc comment wording is a bit awkward (double colon). Consider rephrasing to something like “To opt out of .NET CLI telemetry; it’s unnecessary and can cause issues.”
Suggested change
| /// DOTNET_CLI_TELEMETRY_OPTOUT: To skip any dotnet telemetry: it's unnecessary and can even cause issues. | |
| /// DOTNET_CLI_TELEMETRY_OPTOUT: Opts out of .NET CLI telemetry, which is unnecessary and can cause issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
DOTNET_CLI_TELEMETRY_OPTOUT=1to the minimal environment used for alldotnetinvocations. The telemetry is unnecessary and may even be causing segfaults in some cases.