v2.12.0 testing

[lindseywild]

Release testing & prep for v2.12.0.

[Copilot]

Pull request overview

This PR expands the scanner beyond Axe-only findings by introducing a built-in “reflow” scan plugin and updating typings/issue-filing logic to support findings that don’t have ruleId/html (non-Axe scans).

Changes:

• Add a built-in reflow-scan plugin (320x256 viewport) and wire it into CI/test expectations.
• Make Finding.ruleId and Finding.html optional across action + test types, and update issue filing/body generation accordingly.
• Improve plugin loading to avoid loading a built-in plugin twice when a custom plugin with the same name exists; update docs/workflow examples for the scans input.

Reviewed changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/types.d.ts	Make ruleId/html optional in test Finding type.
tests/site-with-errors.test.ts	Add reflow-scan expectations; make assertions conditional for Axe-specific fields.
sites/site-with-errors/404.html	Add intentionally wide element to trigger reflow finding.
README.md	Document scans input usage in workflow + inputs table.
PLUGINS.md	Update plugin documentation link/reference text.
.github/workflows/test.yml	Run tests with scans: ["axe","reflow-scan"]; update ruby/setup-ruby pin.
.github/scanner-plugins/test-plugin/package.json	Remove old test plugin metadata.
.github/scanner-plugins/test-plugin/index.js	Remove old test plugin implementation.
.github/scanner-plugins/reflow-scan/package.json	Add built-in reflow-scan plugin package metadata.
.github/scanner-plugins/reflow-scan/index.js	Implement built-in horizontal-scroll detection scan.
.github/actions/find/tests/pluginManager.test.ts	Add test coverage for skipping duplicate built-in plugin names.
.github/actions/find/src/types.d.ts	Make html optional (and align with optional ruleId).
.github/actions/find/src/pluginManager.ts	Make addFinding async; skip loading custom plugins that duplicate built-ins by name.
.github/actions/file/tests/openIssue.test.ts	Update expected label ordering.
.github/actions/file/tests/generateIssueBody.test.ts	Add coverage for missing html; make acceptance criteria scanner-agnostic.
.github/actions/file/src/updateFilingsWithNewFindings.ts	Add fallback key logic when ruleId/html are absent.
.github/actions/file/src/types.d.ts	Make ruleId/html optional for filing action.
.github/actions/file/src/openIssue.ts	Avoid creating ruleId label when ruleId is missing.
.github/actions/file/src/generateIssueBody.ts	Handle findings without html; generalize acceptance criteria language.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The scans example value in the inputs table isn't valid JSON (...other plugins can't be parsed). Since the action parses this input via JSON.parse, please update the example to a copy-pastable JSON string (e.g., '["axe","reflow-scan"]' or '["axe","my-custom-plugin"]').

Suggested change

	| `scans` | No | An array of scans (or plugins) to be performed. If not provided, only Axe will be performed. | `'["axe", "reflow-scan", ...other plugins]'` |
	| `scans` | No | An array of scans (or plugins) to be performed. If not provided, only Axe will be performed. | `'["axe","reflow-scan"]'` |

[Copilot]

The fallback getFindingKey (url;scannerType;problemUrl) can easily collide for multiple findings on the same page (e.g., plugins that report multiple elements but share the same problemUrl). Collisions will cause findings to be incorrectly associated with an existing issue, potentially dropping/merging distinct findings. Consider incorporating additional stable fields into the fallback (e.g., problemShort and/or solutionShort, or a dedicated fingerprint field on Finding for non-Axe scans).

Suggested change

	return `${finding.url};${finding.scannerType};${finding.problemUrl}`
	// For non-Axe scans, prefer a stable fingerprint if available; otherwise,
	// include additional stable fields to reduce the risk of collisions.
	if ('fingerprint' in finding && (finding as any).fingerprint) {
	return `${finding.url};${finding.scannerType};${(finding as any).fingerprint}`
	}
	return `${finding.url};${finding.scannerType};${finding.problemUrl};${(finding as any).problemShort ?? ''};${(finding as any).solutionShort ?? ''}`

[JoyceZhu]

Approved for release testing