Skip to content

ci: Merge PR validation workflows and add reason-specific labels#5898

Merged
stephanie-anderson merged 1 commit intomasterfrom
ci/merge-pr-validation-workflows
Mar 27, 2026
Merged

ci: Merge PR validation workflows and add reason-specific labels#5898
stephanie-anderson merged 1 commit intomasterfrom
ci/merge-pr-validation-workflows

Conversation

@stephanie-anderson
Copy link
Copy Markdown
Contributor

Combine close-unvetted-pr.yml and enforce-draft-pr.yml into a single validate-pr.yml workflow so the draft enforcer doesn't run on PRs that were already closed by the vetting check.

How it works:

  • validate-non-maintainer-pr job runs first on opened and reopened events, outputs was-closed if it closes the PR
  • enforce-draft job depends on the first job via needs: and skips when was-closed == 'true' (uses if: always() so it still runs when the first job is skipped or succeeds without closing)

Each closure reason now also gets a specific label alongside violating-contribution-guidelines:

  • missing-issue-reference — no issue ref in body, or referenced issues not found
  • missing-maintainer-discussion — no prior discussion between author and a maintainer
  • issue-already-assigned — referenced issue assigned to someone other than the PR author

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Combine close-unvetted-pr.yml and enforce-draft-pr.yml into a single
validate-pr.yml workflow. The vetting job runs first on opened and
reopened events; the draft enforcement job depends on it and skips if
the PR was already closed.

Each closure reason now gets a specific label in addition to
violating-contribution-guidelines: missing-issue-reference,
missing-maintainer-discussion, or issue-already-assigned.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Langchain

  • Set gen_ai.operation.name and gen_ai.pipeline.name on LLM spans by ericapisani in #5849
  • Broaden AI provider detection beyond OpenAI and Anthropic by ericapisani in #5707
  • Update LLM span operation to gen_ai.generate_text by ericapisani in #5796

Bug Fixes 🐛

Ci

  • Use gh CLI to convert PR to draft by stephanie-anderson in #5874
  • Use GitHub App token for draft PR enforcement by stephanie-anderson in #5871

Openai

  • Always set gen_ai.response.streaming for Responses by alexander-alderman-webb in #5697
  • Simplify Responses input handling by alexander-alderman-webb in #5695
  • Use max_output_tokens for Responses API by alexander-alderman-webb in #5693
  • Always set gen_ai.response.streaming for Completions by alexander-alderman-webb in #5692
  • Simplify Completions input handling by alexander-alderman-webb in #5690
  • Simplify embeddings input handling by alexander-alderman-webb in #5688

Other

  • (google-genai) Guard response extraction by alexander-alderman-webb in #5869
  • (workflow) Fix permission issue with github app and PR draft graphql endpoint by Jeffreyhung in #5887

Documentation 📚

  • Update CONTRIBUTING.md with contribution requirements and TOC by stephanie-anderson in #5896

Internal Changes 🔧

Langchain

  • Add text completion test by alexander-alderman-webb in #5740
  • Add tool execution test by alexander-alderman-webb in #5739
  • Add basic agent test with Responses call by alexander-alderman-webb in #5726
  • Replace mocks with httpx types by alexander-alderman-webb in #5724
  • Consolidate span origin assertion by alexander-alderman-webb in #5723
  • Consolidate available tools assertion by alexander-alderman-webb in #5721

Openai

  • Replace mocks with httpx types for streaming Responses by alexander-alderman-webb in #5882
  • Replace mocks with httpx types for streaming Completions by alexander-alderman-webb in #5879
  • Move input handling code into API-specific functions by alexander-alderman-webb in #5687

Other

  • (ai) Rename generate_text to text_completion by ericapisani in #5885
  • (asyncpg) Normalize query whitespace in integration by ericapisani in #5855
  • Merge PR validation workflows and add reason-specific labels by stephanie-anderson in #5898
  • Add workflow to close unvetted non-maintainer PRs by stephanie-anderson in #5895
  • Exclude compromised litellm versions by alexander-alderman-webb in #5876
  • Reactivate litellm tests by alexander-alderman-webb in #5853
  • Add note to coordinate with assignee before PR submission by sentrivana in #5868
  • Temporarily stop running litellm tests by alexander-alderman-webb in #5851

Other

  • ci+docs: Add draft PR enforcement by stephanie-anderson in #5867

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

Codecov Results 📊

1850 passed | ⏭️ 170 skipped | Total: 2020 | Pass Rate: 91.58% | Execution Time: 3m 32s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 11995 uncovered lines.


Generated by Codecov Action

@stephanie-anderson stephanie-anderson marked this pull request as ready for review March 27, 2026 11:27
@stephanie-anderson stephanie-anderson requested a review from a team as a code owner March 27, 2026 11:27
@stephanie-anderson stephanie-anderson merged commit 75dcc14 into master Mar 27, 2026
164 of 166 checks passed
@stephanie-anderson stephanie-anderson deleted the ci/merge-pr-validation-workflows branch March 27, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants