Add IsSquareMat and IsAntisymmetricMat#6268
Merged
fingolfin merged 5 commits intogap-system:masterfrom Apr 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds new matrix properties to the matrix subsystem, improving reuse and consistency across related predicates.
Changes:
- Introduces
IsSquareMatrix/IsSquareMatand adds test coverage for square vs. non-square matrices. - Introduces
IsAntisymmetricMatrix/IsAntisymmetricMat(with documentation and tests). - Refactors
IsSymmetricMatrixto useIsSquareMatrix, and installs implications that symmetric/antisymmetric matrices are square.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tst/testinstall/matrix.tst |
Adds tests for IsSquareMat and IsAntisymmetricMat. |
lib/matrix.gi |
Implements IsSquareMatrix and IsAntisymmetricMatrix; simplifies IsSymmetricMatrix square-check. |
lib/matrix.gd |
Declares new properties/synonyms, adds GAPDoc entries, and installs implications to IsSquareMatrix. |
doc/ref/matrix.xml |
Includes the new GAPDoc sections in the reference manual. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
IsSquareMat and IsAntisymmetricMat
fingolfin
reviewed
Mar 18, 2026
fingolfin
reviewed
Mar 18, 2026
fingolfin
reviewed
Mar 23, 2026
fingolfin
reviewed
Mar 23, 2026
fingolfin
reviewed
Mar 23, 2026
fingolfin
reviewed
Mar 23, 2026
fingolfin
reviewed
Mar 23, 2026
Co-authored-by: Max Horn <max@quendi.de>
939933a to
99c3007
Compare
Member
|
I've applied my suggestions and added a bunch of test with "empty" matrices / MatrixObj |
fingolfin
approved these changes
Mar 23, 2026
fingolfin
reviewed
Mar 23, 2026
Member
|
Fails because the HAPcryst package also defines |
Member
Member
Author
|
What blocks merge, @fingolfin? |
Member
|
The weekend :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
IsSquareMatrix/IsSquareMatto check whether a matrix is square.Add
IsAntisymmetricMatrix/IsAntisymmetricMatto check whethermat[i,j] = -mat[j,i]for all entries.Both symmetric and antisymmetric matrices imply
IsSquareMatrixviaInstallTrueMethod.IsSymmetricMatrixis simplified to useIsSquareMatrixinstead of an inline dimension check.Fixes #6264.