Skip to content

FIO-9992: check for server when triggering the captcha#6085

Merged
brendanbond merged 2 commits intomasterfrom
FIO-9992
Apr 9, 2025
Merged

FIO-9992: check for server when triggering the captcha#6085
brendanbond merged 2 commits intomasterfrom
FIO-9992

Conversation

@brendanbond
Copy link
Copy Markdown
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9992

Description

We're still using @formio/js for email rendering on the server (soon to change!) and it appears that the captcha trigger is causing problems, namely because the Captcha component appears to the server as a Hidden component. I'm not sure if this is because the vm library is not properly loading premium components or what, but because this is a blocker right before release and because presumably you shouldn't need to trigger the captcha component just to render an email, I've gone ahead and gated the captcha trigger to client-side stuff only.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

n/a

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 7032471 into master Apr 9, 2025
8 checks passed
lane-formio pushed a commit that referenced this pull request Apr 10, 2025
FIO-9992: check for server when triggering the captcha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants