fix(tools): respect manual major version bumps in go.mod#1217
Open
Iam-Karan-Suresh wants to merge 1 commit into
Open
fix(tools): respect manual major version bumps in go.mod#1217Iam-Karan-Suresh wants to merge 1 commit into
Iam-Karan-Suresh wants to merge 1 commit into
Conversation
Iam-Karan-Suresh
force-pushed
the
fix/module-bump-semver-check
branch
2 times, most recently
from
53376ca to
4cdc4c3
Compare
matheuscscp
reviewed
May 25, 2026
| return false, nil | ||
| } | ||
| // Extract current version from the go.mod line and compare with the computed new version. | ||
| matches := m.regex.FindStringSubmatch(oldContent) |
Member
There was a problem hiding this comment.
Why match twice? This call could replace the one right above, and if len(matches) == 0 we return false, nil
Signed-off-by: iam-karan-suresh <karansuresh.info@gmail.com>
Iam-Karan-Suresh
force-pushed
the
fix/module-bump-semver-check
branch
from
4cdc4c3 to
7e60c80
Compare
matheuscscp
reviewed
May 25, 2026
| if len(matches) == 0 { | ||
| return false, nil | ||
| } | ||
| if len(matches) > 1 { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(tools): respect manual major version bumps in go.mod
Previously, the release tool computed module version bumps and blindly
replaced existing versions in go.mod files using regex. This caused
manual major version bumps (e.g., v1.0.0) to be incorrectly downgraded
to computed minor bumps (e.g., v0.18.0), resulting in false-positive
modifications that blocked the release process.
This commit updates the apply function in module_bump.go to:
greater than the internally computed version.
Fixes #1172