Make it possible to extract measurements from an attested certificate without verifying#10
Open
ameba23 wants to merge 8 commits intopeg/attested-tls-cratefrom
Open
Conversation
…hod to extract measurements
ameba23
changed the base branch from
peg/add-attestation-crate
to
peg/attested-tls-crate
5 tasks
…rt-verifier * peg/attested-tls-crate: (32 commits) chore: lint markdown chore: prettify Buildernet measurements should not be fetched on each test run - use a pre-fetched fixture Allow PCR register names to be given as eg. pcr4 in measurements JSON Fix DCAP register field names in measurements JSON format, allowing backwards compatibility Pin to specificy commit of ra-rls Convert test assests to yaml Prettify JSON in test assets Use fixed commit of dcap-qvl Add stable toolchain in CI Switch toolchain to stable, but in CI check for nightly fmt and clippy Move Azure root certs to separate files and include with include_str! Improve normalization for attestation provider URL Fix doccomment for clarity Change field name for clarity Improve check for running on GCP to match GCP documented standard Rename variable for clarity Typo Typo Typo ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During an attested-TLS session there are some cases where we would want to know the measurements from the attestation after the attestation has been verified during the initial handshake.
For example, the Buildernet workflow includes measurements from the session in HTTP request and response headers, so that the HTTP client / server has a further opportunity to verify them.
This PR makes it possible to extract the measurements from a certificate without fully verifying it (since the verification should have already taken place.
It does this by publicly exposing the method to extract the attestation from the certificate, and adding a method to get measurements from an attestation without verifying, for both Azure vTPM and DCAP.
Pairs with flashbots/attested-tls-proxy#154