Skip to content

Fix evaluator#29

Open
Haibib wants to merge 4 commits into
mainfrom
fix-evaluator
Open

Fix evaluator#29
Haibib wants to merge 4 commits into
mainfrom
fix-evaluator

Conversation

@Haibib
Copy link
Copy Markdown

@Haibib Haibib commented Apr 22, 2026 •
edited
Loading

PR Description

  • Added a fake runtime that does naive addition applications
  • Added a front-end for the CLI that can read and parse commands to send to the backend runtime (fake, real, or other future runtimes).

Usage

fix-cli -- <fake|real> -- <commands...>
fix-cli -- <fake|real> --path

Examples

  • cargo run -p evaluator --bin fix-cli fake --path fix/evaluator/add_script.txt
  • cargo run -p evaluator --bin fix-cli fake -- "print(getBlob(apply(makeTree(makeBlob(+), makeBlobInt(1), apply(makeTree(makeBlob(+), makeBlobInt(2), makeBlobInt(3)))))))"

@Haibib Haibib requested a review from Akshay-Srivatsan April 22, 2026 22:40
@Haibib Haibib requested a review from yhdengh May 7, 2026 23:53
yhdengh
yhdengh approved these changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yhdengh yhdengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread Cargo.toml Outdated
[workspace]
members = [ "common", "vmm", "kernel", "macros" , "user", "arca" , "arcane", "fix", "fix/runtime", "fix/handle", "fix/shell" ]
members = [ "common", "vmm", "kernel", "macros" , "user", "arca" , "arcane", "fix", "fix/runtime", "fix/handle", "fix/shell", "fix/evaluator"]
default-members = [ "common", "vmm", "macros", "arca", "fix/handle" ]
Copy link
Copy Markdown
Contributor

@yhdengh yhdengh May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to add this to default-members so that the github cli is running the test cases

Copy link
Copy Markdown
Author

@Haibib Haibib May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks! I added it to default-members and added a makeBlobPath to read bytes in from files.

@Haibib Haibib requested a review from keithw May 8, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yhdengh yhdengh yhdengh approved these changes

@Akshay-Srivatsan Akshay-Srivatsan Awaiting requested review from Akshay-Srivatsan

@keithw keithw Awaiting requested review from keithw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Haibib @yhdengh