[Accton][minipack3ba] platform: Add versionedSensor support for 4.2.10 and 4.2.20#1084
Open
brandonchuang wants to merge 1 commit intofacebook:mainfrom
Open
[Accton][minipack3ba] platform: Add versionedSensor support for 4.2.10 and 4.2.20#1084brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang wants to merge 1 commit intofacebook:mainfrom
Conversation
…0 and 4.2.20
Summary:
This PR adds support for new production hardware revisions including SMB, 3V3_L, and 3V3_R.
Changes:
1. Sensor Service: Added versionedSensors definitions in sensor_service.json.
2. Hardware Versions: Supported the following revisions for SMB and 3V3 units:
- 4.2.10 (Second source)
- 4.2.20
Test Plan:
1. Build & Config: Compilation and configuration validation completed successfully.
2. Hardware Verification: Verified on minipack3ba devices equipped with each SMB/3V3 v4.2.10 & v4.2.20:
- platform_manager started and initialized correctly.
- Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.
- sensor_service correctly identified and resolved versioned configs:
Resolved to versionedPmSensors (v4.2.10/v4.2.20) for SMB at /SMB_SLOT@0
Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
- sensor_service_client test cases passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.........................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...............................................................Passed
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
ruff format..........................................(no files to check)Skipped
Summary:
This PR adds support for new production hardware revisions including SMB, 3V3_L, and 3V3_R.
Changes:
Test Plan:
- platform_manager started and initialized correctly.
- Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.
[mp3ba_smb_3v3_4.2.10_log] platform_manager.txt
[mp3ba_smb_3v3_4.2.10_log] platform_manager_hw_test.txt
[mp3ba_smb_3v3_4.2.20_log] platform_manager.txt
[mp3ba_smb_3v3_4.2.20_log] platform_manager_hw_test.txt
[mp3ba_smb_3v3_4.2.10_log] sensor_service.txt
[mp3ba_smb_3v3_4.2.10_log] sensor_service_hw_test.txt
[mp3ba_smb_3v3_4.2.20_log] sensor_service.txt
[mp3ba_smb_3v3_4.2.20_log] sensor_service_hw_test.txt
- sensor_service correctly identified and resolved versioned configs:
Resolved to versionedPmSensors (v4.2.10/v4.2.20) for SMB at /SMB_SLOT@0
Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
- sensor_service_client test cases passed.
[mp3ba_smb_3v3_4.2.10_log] sensor_service_client.txt
[mp3ba_smb_3v3_4.2.20_log] sensor_service_client.txt