Skip to content

[Accton][minipack3ba] platform: Add versionedSensor support for 4.2.10 and 4.2.20#1084

Open
brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang:mp3ba_smb_3v3_4.2
Open

[Accton][minipack3ba] platform: Add versionedSensor support for 4.2.10 and 4.2.20#1084
brandonchuang wants to merge 1 commit intofacebook:mainfrom
brandonchuang:mp3ba_smb_3v3_4.2

Conversation

@brandonchuang
Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    clang-format.........................................(no files to check)Skipped
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...............................................................Passed
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped
    ruff format..........................................(no files to check)Skipped

Summary:

This PR adds support for new production hardware revisions including SMB, 3V3_L, and 3V3_R.

Changes:

  1. Sensor Service: Added versionedSensors definitions in sensor_service.json.
  2. Hardware Versions: Supported the following revisions for SMB and 3V3 units:
    • 4.2.10 (Second source)
    • 4.2.20

Test Plan:

  1. Build & Config: Compilation and configuration validation completed successfully.
  2. Hardware Verification: Verified on minipack3ba devices equipped with each SMB/3V3 v4.2.10 & v4.2.20:
    - platform_manager started and initialized correctly.
    - Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.
    [mp3ba_smb_3v3_4.2.10_log] platform_manager.txt
    [mp3ba_smb_3v3_4.2.10_log] platform_manager_hw_test.txt
    [mp3ba_smb_3v3_4.2.20_log] platform_manager.txt
    [mp3ba_smb_3v3_4.2.20_log] platform_manager_hw_test.txt
    [mp3ba_smb_3v3_4.2.10_log] sensor_service.txt
    [mp3ba_smb_3v3_4.2.10_log] sensor_service_hw_test.txt
    [mp3ba_smb_3v3_4.2.20_log] sensor_service.txt
    [mp3ba_smb_3v3_4.2.20_log] sensor_service_hw_test.txt
    - sensor_service correctly identified and resolved versioned configs:
    Resolved to versionedPmSensors (v4.2.10/v4.2.20) for SMB at /SMB_SLOT@0
    Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
    Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
    - sensor_service_client test cases passed.
    [mp3ba_smb_3v3_4.2.10_log] sensor_service_client.txt
    [mp3ba_smb_3v3_4.2.20_log] sensor_service_client.txt

…0 and 4.2.20

Summary:
  This PR adds support for new production hardware revisions including SMB, 3V3_L, and 3V3_R.

Changes:
  1. Sensor Service: Added versionedSensors definitions in sensor_service.json.
  2. Hardware Versions: Supported the following revisions for SMB and 3V3 units:
     - 4.2.10 (Second source)
     - 4.2.20

Test Plan:
  1. Build & Config: Compilation and configuration validation completed successfully.
  2. Hardware Verification: Verified on minipack3ba devices equipped with each SMB/3V3 v4.2.10 & v4.2.20:
    - platform_manager started and initialized correctly.
    - Executed platform_manager_hw_test and sensor_service_hw_test; all test cases passed.
    - sensor_service correctly identified and resolved versioned configs:
      Resolved to versionedPmSensors (v4.2.10/v4.2.20) for SMB at /SMB_SLOT@0
      Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_L at /SMB_SLOT@0/OPTICL_SLOT@0
      Resolved to versionedPmSensors (v4.2.10/v4.2.20) for 3V3_R at /SMB_SLOT@0/OPTICR_SLOT@0
    - sensor_service_client test cases passed.
@brandonchuang brandonchuang requested a review from a team as a code owner April 15, 2026 03:00
@meta-cla meta-cla bot added the CLA Signed label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant