Conversation
Updates xpbuild.yml to explicitly specify cmake_workflow_preset_suffix: Release
for all build jobs (linux, macos, windows). This ensures consistent Release
cmake workflow preset across all platforms and matches the configuration used
by other externpro projects like nodeng.
Previously using empty with: {} blocks, now explicitly setting the Release
preset for proper cmake workflow preset configuration.
…essages Adds COND_OPEN and COND_CLOSE variables to wrap the Threads package configuration with a conditional check. This prevents duplicate "Found Threads" messages when the package is included multiple times in the same build. The implementation uses a cache variable __xp_threads_found_message_shown to track whether the message has already been displayed, while still ensuring Threads_FOUND is set to TRUE for subsequent includes. This improves build output cleanliness while maintaining proper package functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use cmake workflow preset
<platform>Release(no reason to build Debug)add conditional message handling to prevent duplicate "Threads found" messages from
threads-config.cmake