feat: handle circular structure serialization#7275
Open
leandro-costa-oliveira wants to merge 1 commit into
Open
feat: handle circular structure serialization#7275leandro-costa-oliveira wants to merge 1 commit into
leandro-costa-oliveira wants to merge 1 commit into
Conversation
0716583 to
1ea6f49
Compare
1ea6f49 to
ccf2192
Compare
Closed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
res.jsoninlib/response.jscallsstringifywhich fails if a object with circular structure is passed.This is pretty common when you have calls using
axioslib, the axios errors include the response object which have circular structure. Since a bunch a libs rely on axios, this is a pretty common cause of issues.Example of Stack Trace
Doing a
soapcall withrouting-controllerson top ofexpress, fails to parse the error.Tests
Added tests in
test/res.jsonandtest/res.jsonpsimulating the circular structure.