Skip to content

👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files#332

Draft
mmcky wants to merge 4 commits intomainfrom
code-load-utf8-standard
Draft

👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files#332
mmcky wants to merge 4 commits intomainfrom
code-load-utf8-standard

Conversation

@mmcky
Copy link
Copy Markdown
Member

@mmcky mmcky commented Jun 1, 2021

It looks like windows platform doesn't by default always use utf-8 when reading text from files. I think this is a sensible cross-platform default.

QuantEcon/lecture-python.myst#144

There is also a related issue reported on stackoverflow

mmcky added a commit to QuantEcon/lecture-python.myst that referenced this pull request Jun 1, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 1, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.43%. Comparing base (e39132e) to head (c234bae).
⚠️ Report is 203 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          12       12           
  Lines        1337     1337           
=======================================
  Hits         1169     1169           
  Misses        168      168           
Flag Coverage Δ
pytests 87.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mmcky added a commit to QuantEcon/lecture-python.myst that referenced this pull request Jun 1, 2021
* enable execution checks for windows, linux, os x

* test on PR first

* add interpolation install from conda-forge

* [temp] disable windows testing until executablebooks/MyST-NB#332

* turn of activate on push and set to schedule based testing
@mmcky mmcky requested a review from chrisjsewell June 1, 2021 06:43
@mmcky mmcky changed the title [code load] Enable utf-8 as the standard encoding for reading code from files 👌 IMPROVE: [code load] Enable utf-8 as the standard encoding for reading code from files Jun 7, 2021
@mmcky mmcky added the on-hold label Jun 7, 2021
@mmcky mmcky marked this pull request as draft June 7, 2021 07:35
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Apr 24, 2025

This looks reasonable to me, but the code has been refactored enough in the past few years that it needs some fixing up.

Would you @mmcky be interested of resurrecting it? Unfortunately I don't see the old CI status any more to figure out the reason why it got the "on hold" label and draft status, if it's too much work to fix up this PR I would recommend to close it and open an issue for tracking the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants