Skip to content

chore: docs restyle for new landing page#3210

Merged
tac0turtle merged 2 commits intomainfrom
marko/docs_restyle
Apr 13, 2026
Merged

chore: docs restyle for new landing page#3210
tac0turtle merged 2 commits intomainfrom
marko/docs_restyle

Conversation

@tac0turtle
Copy link
Copy Markdown
Contributor

Overview

This pr ties and is blocked by the new landing page being launched

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 30, 2026

Claude finished @tac0turtle's task in 1m 27s —— View job


Code Review: docs restyle for new landing page

  • Gather context and read changed files
  • Review VitePress config changes (docs/.vitepress/config.ts)
  • Review CSS/theme changes (docs/.vitepress/theme/style.css)
  • Review landing page content (docs/index.md)
  • Review package dependency changes (docs/package.json)
  • Post comprehensive review

Overall the restyling is clean and well-structured — the new brand theme is coherent and the CSS organization is solid. A few issues worth addressing:

Bug: og:description is set to a boolean

docs/.vitepress/config.ts:146

{
  name: "og:description",
  content: pageData.frontmatter.layout === `${pageData.description}`,
}

This evaluates to content: true or content: false — a comparison operator (===) was used instead of a conditional. The intent appears to be something like:

{
  name: "og:description",
  content: pageData.frontmatter.layout === "home"
    ? "Launch Fast. Build Your Own Network."
    : pageData.description,
}

Fix this →

Accessibility: user-scalable=no in viewport

docs/.vitepress/config.ts:52-55

content: "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no",

user-scalable=no prevents users from pinching to zoom, which violates WCAG 2.1 SC 1.4.4 and is a known accessibility barrier for low-vision users. Consider removing maximum-scale=1.0, user-scalable=no.

Fix this →

Logo: both light and dark variants point to the same file

docs/.vitepress/config.ts:121-125

logo: {
  alt: "Evolve Logo",
  light: "/img/evolve-logo-dark.svg",
  dark: "/img/evolve-logo-dark.svg",   // ← same as light
},

Since appearance: false disables dark mode this has no visible impact today, but the naming is confusing and will cause a bug if dark mode is ever re-enabled. Either add a proper evolve-logo-light.svg or rename to evolve-logo.svg for clarity.

Minor: unused constants.js import in index.md

docs/index.md:8

import constants from './.vitepress/constants/constants.js'

No {{ constants.X }} variables are referenced in the rendered content. If this import is no longer needed it can be removed to avoid a dead-code warning at build time.

Minor: hard-coded colors in index.md inline styles

docs/index.md:73-93

The inline <style> block hard-codes colors like #DAE4E7, #B8A6FF, #000000, #3C3C3C that duplicate the CSS custom properties already defined in style.css. Consider referencing the brand tokens instead:

border: 1px solid var(--ev-diagonal);
/* hover */
border-color: var(--ev-purple);
color: var(--ev-foreground);

This also means the styles could be moved to style.css entirely so they're available across pages.

Minor: predev/prebuild scripts use npm while project uses yarn

docs/package.json:6,8

"predev": "[ -d node_modules ] || npm install",
"prebuild": "[ -d node_modules ] || npm install",

The repo uses yarn (there's a yarn.lock), so these hooks install with the wrong package manager. Consider switching to yarn install or removing these hooks and relying on the developer to have installed deps already.


Good work overall — the visual direction is strong, the CSS is well-organized into labeled sections, and the VitePress config is clean and readable.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-13 09:54 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedApr 13, 2026, 9:51 AM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.79%. Comparing base (6f8e093) to head (c2487a6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3210      +/-   ##
==========================================
- Coverage   61.81%   61.79%   -0.02%     
==========================================
  Files         120      120              
  Lines       12670    12670              
==========================================
- Hits         7832     7830       -2     
- Misses       3960     3962       +2     
  Partials      878      878              
Flag Coverage Δ
combined 61.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the content, but the UI looks so much better.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

Warning

Rate limit exceeded

@tac0turtle has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 4 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 25 minutes and 4 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 71ba6a39-c096-4b21-b8b7-547086bc5aae

📥 Commits

Reviewing files that changed from the base of the PR and between 6f8e093 and c2487a6.

⛔ Files ignored due to path filters (11)
  • docs/package-lock.json is excluded by !**/package-lock.json
  • docs/public/favicon/android-chrome-192x192.png is excluded by !**/*.png
  • docs/public/favicon/android-chrome-512x512.png is excluded by !**/*.png
  • docs/public/favicon/apple-touch-icon.png is excluded by !**/*.png
  • docs/public/favicon/favicon-16x16.png is excluded by !**/*.png
  • docs/public/favicon/favicon-32x32.png is excluded by !**/*.png
  • docs/public/favicon/favicon.ico is excluded by !**/*.ico
  • docs/public/img/evolve-logo-dark.svg is excluded by !**/*.svg
  • docs/public/img/evolve-logo.svg is excluded by !**/*.svg
  • docs/public/og-image.png is excluded by !**/*.png
  • docs/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (4)
  • docs/.vitepress/config.ts
  • docs/.vitepress/theme/style.css
  • docs/index.md
  • docs/package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch marko/docs_restyle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tac0turtle tac0turtle merged commit a9e08e8 into main Apr 13, 2026
16 of 20 checks passed
@tac0turtle tac0turtle deleted the marko/docs_restyle branch April 13, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants