fix: initial steward values [ENG-3411]

[speaker-ender]

Ticket ENG-3411

Description Of Changes

Fixes an issue where the state of the stewards filter on the root action center would be out of sync with the url and requests when logged in as a steward assigned to a monitor.

Code Changes

Steps to Confirm

1. Create a user with viewer and reviewer permissions
2. Add a new monitor and assign the previously created user as a steward to that monitor
3. Log in as the user you created
4. Confirm that navigating to the root action center screen defaults the stewards filter to assigned to me
5. Confirm that clearing the filter removes the value and shows all monitors

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Updates unreleased work already in Changelog, no new entry necessary
• UX feedback:
  • All UX related changes have been reviewed by a designer
  • No UX review needed
• Followup issues:
  • Followup issues created
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Apr 15, 2026 2:39pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Apr 15, 2026 2:39pm

[github-actions]

Title	Lines	Statements	Branches	Functions
admin-ui		6.1% (2663/43637)	5.22% (1293/24736)	4.19% (542/12917)
fides-js		78.98% (1962/2484)	65.55% (1214/1852)	72.57% (336/463)
privacy-center		85.97% (331/385)	81.36% (179/220)	78.87% (56/71)

[claude]

Code Review: PR #7914 — fix: initial steward values [ENG-3411]

Scope: Frontend only (TypeScript/React). No backend changes.

This PR fixes an out-of-sync steward filter on the action center root page by removing the defaultStewardFilter default from SearchFormQueryState and instead applying it via a useEffect after the user's monitor assignments are fetched. It also exposes setSearchForm from useSearchForm and changes showSearch + optionFilterProp to an object syntax.

---

Critical (must fix)

MonitorListSearchForm.tsx — showSearch={{ optionFilterProp: "label" }} is not a valid Ant Design API. Select's showSearch prop accepts a boolean, not an object. The object is truthy so search is enabled, but optionFilterProp inside it is silently ignored, causing the dropdown to filter by value instead of label. Steward name search will break. See inline comment.

---

Suggestions

MonitorList.tsx — formProps.setSearchForm inside the useEffect and its dependency array is slightly indirect. Destructuring setSearchForm out of formProps at the call site would be cleaner and make the dependency array easier to read. See inline comment.

MonitorList.tsx (timing) — defaultStewardFilter is undefined until useGetUserMonitorsQuery resolves, so the component will briefly render and fire an API call without the steward filter before the effect kicks in. This is the same race that existed before (the old defaultStewardFilter argument to SearchFormQueryState had the same issue), so it's not a regression. If the flash is unacceptable in the future, the fix would be to defer rendering the monitor list until the user-monitors query has resolved.

MonitorList.tsx (initialValues) — steward_key: defaultStewardFilter ?? null in initialValues is always null on the first render (since the query hasn't resolved yet) and is then overwritten by the effect. The line is doing nothing useful for steward_key and its intent is slightly misleading — a comment explaining why would help future readers.

---

Nit

changelog/7914-fix-steward-filter.yaml — type field is blank; should be Fixed. See inline comment.

---

One blocking issue (showSearch object syntax), otherwise the approach is sound.

🔬 Codegraph: connected (46711 nodes)

---

💡 Write /code-review in a comment to re-run this review.

[gilluminate]

testing worked as expected!