Skip to content

Cleanup Tool.compatible_with_this_os method. NFC#1699

Open
sbc100 wants to merge 1 commit intomainfrom
cleanup_compatible_with_this_os
Open

Cleanup Tool.compatible_with_this_os method. NFC#1699
sbc100 wants to merge 1 commit intomainfrom
cleanup_compatible_with_this_os

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented Apr 14, 2026

  • Remove some "return after else" patterns
  • Assert that self.os of one of the valid values.
  • Use == rather then in for comparisons with self.os since we only support a fixes set of values.

@sbc100 sbc100 changed the title Simplify Tool.compatible_with_this_os method. NFC Cleanup Tool.compatible_with_this_os method. NFC Apr 14, 2026
@sbc100 sbc100 force-pushed the cleanup_compatible_with_this_os branch from aafd6c9 to 2dbc9ce Compare April 14, 2026 23:31
@sbc100 sbc100 requested a review from kripken April 14, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants