Run tests with latest Ember CLI#134
Merged
simonihmig merged 1 commit intomainfrom Jul 6, 2023
Merged
Conversation
simonihmig
force-pushed
the
update-embercli
branch
2 times, most recently
from
a4524fd to
9675762
Compare
Collaborator
Author
|
TS tests failing due to #133 |
simonihmig
commented
Jul 2, 2023
| let cwd = ''; | ||
| let tmpDir = ''; | ||
| let distDir = ''; | ||
| describe(`--typescript with ${packageManager}`, () => { |
Collaborator
Author
There was a problem hiding this comment.
Basically just white-space changes here due to putting this into previous describe() that runs for every package manager. Best reviewed with Hide whitespace enabled!
Use canary version of ember-cli on master branch, until we ge get a stable/beta release on npm, which includes better support of `--typescript` ([PR](ember-cli/ember-cli#10283)). Cleans up previous weirdness.
simonihmig
force-pushed
the
update-embercli
branch
from
9675762 to
d048079
Compare
NullVoxPopuli
approved these changes
Jul 5, 2023
aklkv
pushed a commit
to aklkv/addon-blueprint
that referenced
this pull request
Feb 8, 2026
…bercli Run tests with latest Ember CLI
aklkv
pushed a commit
to aklkv/addon-blueprint
that referenced
this pull request
Feb 8, 2026
…bercli Run tests with latest Ember CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use canary version of ember-cli on master branch, until we get a stable/beta release on npm, which includes better support of
--typescript(PR). Cleans up previous weirdness.