Integration tests for Elekto with GitHub oauth mocking#122
Open
Integration tests for Elekto with GitHub oauth mocking#122
Conversation
oduludo
force-pushed
the
integration-tests
branch
3 times, most recently
from
10857e9 to
4aa0328
Compare
oduludo
force-pushed
the
integration-tests
branch
from
4aa0328 to
8cb8f32
Compare
oduludo
commented
Feb 14, 2026
| AUTH_STATE = 'authentication' | ||
|
|
||
| # Github Endpoints | ||
| GITHUB_AUTHORIZE = 'https://github.com/login/oauth/authorize' |
Collaborator
Author
There was a problem hiding this comment.
These values effectively remain unchanged as long as there is no INTEGRATION_TEST env variable set to true.
oduludo
commented
Feb 14, 2026
| POSTGRES_PASSWORD: root | ||
| volumes: | ||
| - pgdata:/var/lib/postgresql/data | ||
| - pgdata:/var/lib/postgresql |
Collaborator
Author
There was a problem hiding this comment.
Changed due to docker-library/postgres#1259
oduludo
commented
Feb 14, 2026
| ./console --run | ||
| else | ||
| if [ $APP_CONNECT == "socket" ]; then | ||
| if [ "$APP_CONNECT" == "socket" ]; then |
Collaborator
Author
There was a problem hiding this comment.
IIRC I had to wrap this in tags because the elekto service wouldn't start in the integration test stack without these quotes. I'm not a bash specialist, but my impression is this change is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests for the Elekto application. It's containerized with all required services being in the stack. A simple GitHub mocking service is included to simulate authorization flows and case sensitivity issues.
More integration tests have to be written still, but this PR introduces the foundational layer to do so.