Skip to content

add failure_store to beats monitoring template#144883

Merged
leehinman merged 7 commits intoelastic:mainfrom
leehinman:10642_metricbeat_failure_store_metric
Apr 15, 2026
Merged

add failure_store to beats monitoring template#144883
leehinman merged 7 commits intoelastic:mainfrom
leehinman:10642_metricbeat_failure_store_metric

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

Add failure_store fields to monitoring templates.

Relates: elastic/beats#48068
Relates: elastic/beats#49452

@leehinman leehinman requested a review from a team as a code owner March 24, 2026 18:14
@elasticsearchmachine elasticsearchmachine added v9.4.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Mar 24, 2026
Copy link
Copy Markdown
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leehinman that looks good! I have two comments:

  1. You also need to increment STACK_MONITORING_REGISTRY_VERSION in MonitoringRegistryTemplate
  2. I'm not sure you need to modify monitoring-es-mb.json unless you also modified Beats internal monitoring module

@ioanatia ioanatia added >enhancement Team:Stack Monitoring and removed needs:triage Requires assignment of a team area label labels Mar 25, 2026
@leehinman
Copy link
Copy Markdown
Contributor Author

  1. You also need to increment STACK_MONITORING_REGISTRY_VERSION in MonitoringRegistryTemplate

Updated. Hopefully I got it right.

  1. I'm not sure you need to modify monitoring-es-mb.json unless you also modified Beats internal monitoring module

The original change is elastic/beats#48068, and it means that all the beats that use elasticsearch for an output will collect the failure_store metric. And it should be reported by the vistor that reads the registry for libbeat.

Copy link
Copy Markdown
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@leehinman leehinman merged commit e08d05c into elastic:main Apr 15, 2026
34 of 35 checks passed
@leehinman leehinman added backport v9.4.1 auto-backport Automatically create backport pull requests when merged and removed backport labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Stack Monitoring v9.4.1 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants