[TEST] Add rounding to avg_over_time tests#144882
Merged
kkrik-es merged 7 commits intoelastic:mainfrom Mar 27, 2026
Merged
Conversation
kkrik-es
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
sidosera
reviewed
Mar 24, 2026
| 718.6666666666666 | prod | 2024-05-10T00:20:00.000Z | 0.6186666666666666 | ||
| 778.8333333333334 | qa | 2024-05-10T00:20:00.000Z | 0.6788333333333334 | ||
| 400.4555555555555 | staging | 2024-05-10T00:20:00.000Z | 0.30045555555555553 | ||
| TS k8s |
sidosera
approved these changes
Mar 24, 2026
Contributor
sidosera
left a comment
sidosera
left a comment
There was a problem hiding this comment.
Thank you for fixing and properly formatting those tests!
Removed muted tests for TsidExtractingIdFieldMapperTests and CsvIT.
Member
Author
|
I've been trying to get this in for a week now.. This change affects a specific test file and all related tests pass, so it feels safe to submit. |
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 30, 2026
* Add rounding to avg_over_time tests * Remove muted tests for specific classes and methods Removed muted tests for TsidExtractingIdFieldMapperTests and CsvIT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite doesn't use segment merging so there are small rounding errors.
Fixes #144719