Unions: Support inheritance for TryGetValue methods#82884
Merged
AlekseyTs merged 1 commit intodotnet:features/Unionsfrom Mar 29, 2026
Merged
Unions: Support inheritance for TryGetValue methods#82884AlekseyTs merged 1 commit intodotnet:features/Unionsfrom
AlekseyTs merged 1 commit intodotnet:features/Unionsfrom
Conversation
jjonescz
approved these changes
Mar 23, 2026
| if (!inputUnionType.IsDefinition) | ||
| { | ||
| if (!inputUnionType.IsDefinition) | ||
| while (declaringType.OriginalDefinition != (object)possiblyConstructedOrSubstitutedType.OriginalDefinition) |
Member
There was a problem hiding this comment.
Why did we go from iterating baseType1/baseType2 inheritance chains to iterating just one and fixing up the other via the inner while loop? Does it make observable difference?
Contributor
Author
There was a problem hiding this comment.
We are just doing slightly less work if we are dealing with a non-generic type, or dealing with generic definition. The baseType2 wasn't used then. With this change we don't even calculate it. This also aligns code with the other added helpers around TryGetValue
Contributor
Author
|
@RikkiGibson, @dotnet/roslyn-compiler For a second review. |
3 similar comments
Contributor
Author
|
@RikkiGibson, @dotnet/roslyn-compiler For a second review. |
Contributor
Author
|
@RikkiGibson, @dotnet/roslyn-compiler For a second review. |
Contributor
Author
|
@RikkiGibson, @dotnet/roslyn-compiler For a second review. |
RikkiGibson
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow