Fix review comments for CSV string.Split benchmarks#5202
Closed
Fix review comments for CSV string.Split benchmarks#5202
Conversation
Agent-Logs-Url: https://github.com/dotnet/performance/sessions/5a3db2a2-dd61-41bc-9847-4083906d08a5 Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
… style, add THIRD-PARTY-NOTICES.TXT Agent-Logs-Url: https://github.com/dotnet/performance/sessions/5a3db2a2-dd61-41bc-9847-4083906d08a5 Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code for all comments in review thread
Fix review comments for CSV string.Split benchmarks
Apr 11, 2026
Member
|
@copilot push to the original pr we don't need this new one |
Contributor
Author
Unfortunately I'm only able to push to the branch of the PR I was invoked on ( |
Member
|
Closing: review fixes have been cherry-picked onto PR #4659 (branch pranas-string-split). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all review comments from the CSV
string.Splitbenchmark PR. Merges the original changes and applies the requested fixes.Changes
Shorter CSV filenames: Renamed long-named files to avoid Windows path-length build failures. Original source URLs preserved in comments and
THIRD-PARTY-NOTICES.TXT.Monthly_Motor_Fuel_Sales_Reported_by_States__Selected_Data_from_FHWA_Monthly_Motor_Fuel_Report.csv→motor_fuel_sales.csv500_Cities__City-level_Data__GIS_Friendly_Format___2019_release.csv→500_cities.csvCached file I/O:
CsvCorpus()previously calledReadInputFile()inline on every enumeration (BDN enumeratesArgumentsSourcemultiple times during discovery and per job). Replaced with staticLazy<string[]>fields loaded once on first access:Style fix:
new object []{ ... }→new object[] { ... }to match surrounding entries.Third-party notices: Added
THIRD-PARTY-NOTICES.TXTdocumenting all six CSV sources (CMS, DOT, Census Bureau, USDA, EPA, CDC — all U.S. government public domain data).