Fix compilation errors in OrderedDictionary benchmarks#5201
Closed
Fix compilation errors in OrderedDictionary benchmarks#5201
Conversation
Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
…in attribute, unused using directive Agent-Logs-Url: https://github.com/dotnet/performance/sessions/83d3fcf6-8922-4887-b31b-bf1c64dfecc4 Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Fix compilation errors in OrderedDictionary benchmarks
Apr 11, 2026
Member
|
@copilot put these fixes in the original PR and close this one |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three compilation issues in the new
OrderedDictionary<,>benchmarks, caught in code review.Perf_OrderedDictionary.cs:value ?? keydoesn't compile for unconstrainedT— replaced withvalue is null ? key : valueIndexerSet.cs: Collection expression[ ... ]is invalid in attribute arguments — replaced withnew[] { ... }TryAddDefaultSize.cs: Removed unusedusing System.Drawing;These fixes have been applied directly to the
pranas-ordered-dictbranch (PR #4557).