Remove duplicate @ prefix from issueAuthor in GitOps#11082
Open
akoeplinger wants to merge 1 commit intodotnet:mainfrom
Open
Remove duplicate @ prefix from issueAuthor in GitOps#11082akoeplinger wants to merge 1 commit intodotnet:mainfrom
akoeplinger wants to merge 1 commit intodotnet:mainfrom
Conversation
https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262 (internal Microsoft link) changed the ` ${issueAuthor}` placeholder to include the `@` character. Remove the one we added so we don't duplicate it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
akoeplinger
requested review from
jonathanpeppers and
simonrozsival
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitOps.PullRequestIssueManagement policy configuration to avoid double-mentioning issue authors now that ${issueAuthor} includes the @ prefix upstream.
Changes:
- Remove the hardcoded
@before${issueAuthor}in the inactivity auto-close reply - Remove the hardcoded
@before${issueAuthor}in theneed-infolabel auto-reply
| actions: | ||
| - addReply: | ||
| reply: Hi @${issueAuthor}. Due to inactivity, we will be closing this issue. Please feel free to re-open this issue if the issue persists. For enhanced visibility, if over 7 days have passed, please open a new issue and link this issue there. Thank you. | ||
| reply: Hi ${issueAuthor}. Due to inactivity, we will be closing this issue. Please feel free to re-open this issue if the issue persists. For enhanced visibility, if over 7 days have passed, please open a new issue and link this issue there. Thank you. |
There was a problem hiding this comment.
This edited line appears to have a different line ending (LF-only) compared to the rest of the file (CRLF shown on surrounding lines in this diff). Please normalize the file’s line endings to avoid mixed EOLs in the same YAML file.
| then: | ||
| - addReply: | ||
| reply: Hi @${issueAuthor}. We have added the "need-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time. | ||
| reply: Hi ${issueAuthor}. We have added the "need-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time. |
There was a problem hiding this comment.
This edited line appears to have a different line ending (LF-only) compared to the rest of the file (CRLF shown on surrounding lines in this diff). Please normalize the file’s line endings to avoid mixed EOLs in the same YAML file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262 (internal Microsoft link) changed the
${issueAuthor}placeholder to include the@character.Remove the one we added so we don't duplicate it.