Skip to content

Quarantine flaky tests #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmedynski merged 2 commits into from
Apr 13, 2026
Merged

Quarantine flaky tests #4170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b1b0ab
Quarantine flaky tests with [Trait("Category", "flaky")]
paulmedynski Apr 9, 2026
e70a153
Quarantine flaky tests: ConnectionFailoverTests and DataReaderTest.Ca…
paulmedynski Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/FunctionalTests/LocalizationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public class LocalizationTest
[InlineData("ru-RU")]
[InlineData("zh-Hans")]
[InlineData("zh-Hant")]
[Trait("Category", "flaky")]
public void Localization_Tests(string culture)
Comment thread
paulmedynski marked this conversation as resolved.
{
string localized = GetLocalizedErrorMessage(culture);
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/AsyncTest/AsyncTimeoutTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public enum AsyncAPI
// Synapse: WAITFOR DELAY not supported [Parse error at line: 1, column: 1: Incorrect syntax near 'WAITFOR'.]
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
[ClassData(typeof(AsyncTimeoutTestVariations))]
[Trait("Category", "flaky")]
public static void TestDelayedAsyncTimeout(AsyncAPI api, string commonObj, int delayPeriod, bool marsEnabled) =>
RunTest(api, commonObj, delayPeriod, marsEnabled);

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectionPoolTest/ConnectionPoolTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ public static class ConnectionPoolTest
/// </summary>
[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
[ClassData(typeof(ConnectionPoolConnectionStringProvider))]
[Trait("Category", "flaky")]
public static void BasicConnectionPoolingTest(string connectionString)
{
SqlConnection.ClearAllPools();
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataReaderTest/DataReaderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,7 @@ public _Row(int id, Guid documentIdentificationId, string name, string value)
}
}

[Trait("Category", "flaky")]
[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
public static async Task CanReadAwkwardDataLengths()
{
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/DataStreamTest/DataStreamTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ public static void GetXmlReader_ReturnsXmlReaderCorrectly(string connectionStrin

[ConditionalTheory(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
[MemberData(nameof(ConnectionStrings))]
[Trait("Category", "flaky")]
public static void ReadStream_ReadsStreamDataCorrectly(string connectionString)
{
ReadStream(connectionString);
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/ManualTests/TracingTests/MetricsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ public void ReclaimedConnectionsCounter_Functional()
}

[ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup))]
[Trait("Category", "flaky")]
public void ConnectionPoolGroupsCounter_Functional()
{
SqlConnection.ClearAllPools();
Expand Down
5 changes: 5 additions & 0 deletions src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionFailoverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ namespace Microsoft.Data.SqlClient.UnitTests.SimulatedServerTests
public class ConnectionFailoverTests
{
//TODO parameterize for transient errors
[Trait("Category", "flaky")]
[Theory]
[InlineData(40613)]
[InlineData(42108)]
Expand Down Expand Up @@ -74,6 +75,7 @@ public void TransientFault_NoFailover_DoesNotClearPool(uint errorCode)
Assert.Equal(0, failoverServer.PreLoginCount);
}

[Trait("Category", "flaky")]
[Fact]
public void NetworkError_TriggersFailover_ClearsPool()
{
Expand Down Expand Up @@ -239,6 +241,7 @@ public void NetworkDelay_ShouldConnectToPrimary()
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkError_WithUserProvidedPartner_RetryDisabled_ShouldConnectToFailoverPartner()
{
using TdsServer failoverServer = new(
Expand Down Expand Up @@ -286,6 +289,7 @@ public void NetworkError_WithUserProvidedPartner_RetryDisabled_ShouldConnectToFa
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkError_WithUserProvidedPartner_RetryEnabled_ShouldConnectToFailoverPartner()
{
using TdsServer failoverServer = new(
Expand Down Expand Up @@ -430,6 +434,7 @@ public void TransientFault_RetryDisabled_ShouldFail(uint errorCode)
[InlineData(40613)]
[InlineData(42108)]
[InlineData(42109)]
[Trait("Category", "flaky")]
public void TransientFault_WithUserProvidedPartner_ShouldConnectToPrimary(uint errorCode)
{
// Arrange
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Data.SqlClient/tests/UnitTests/SimulatedServerTests/ConnectionRoutingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ public void NetworkDelayAtRoutedLocation_RetryDisabled_ShouldSucceed(bool multiS
}

[Fact]
[Trait("Category", "flaky")]
public void NetworkTimeoutAtRoutedLocation_RetryDisabled_ShouldFail()
{
// Arrange
Expand Down
Loading