-
Notifications
You must be signed in to change notification settings - Fork 328
pwsh via dotnet tool #4134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
pwsh via dotnet tool #4134
Changes from all commits
4a44cd0
2fe538c
02f53d2
1b71541
91290d5
61ae6de
206dacd
71fba83
a3d2516
83b7397
f9a0381
0f6413e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ################################################################################# | ||
| # Licensed to the .NET Foundation under one or more agreements. # | ||
| # The .NET Foundation licenses this file to you under the MIT license. # | ||
| # See the LICENSE file in the project root for more information. # | ||
| ################################################################################# | ||
|
|
||
| # Restores dotnet CLI tools defined in dotnet-tools.json. | ||
| # This step should be invoked after install-dotnet.yml and before any build | ||
| # steps that depend on the restored tools (e.g. pwsh, apicompat). | ||
|
|
||
| steps: | ||
| - script: dotnet tool restore | ||
| displayName: Restore .NET Tools | ||
| workingDirectory: $(Build.SourcesDirectory) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ | |
| <OutputPath>$(ArtifactPath)$(AssemblyName).ref/$(ReferenceType)-$(Configuration)/</OutputPath> | ||
| </PropertyGroup> | ||
|
|
||
|
|
||
| <!-- Trim Docs for IntelliSense ====================================== --> | ||
| <!-- | ||
| It has been determined that including the remarks section in IntelliSense docs looks bad in | ||
|
|
@@ -48,10 +49,8 @@ | |
| AfterTargets="Build" | ||
| Condition="'$(IsCrossTargetingBuild)' != 'true' AND '$(GenerateDocumentationFile)' == 'true'"> | ||
| <PropertyGroup> | ||
| <PowerShellCommand Condition="'$(OS)' == 'Windows_NT'">powershell.exe</PowerShellCommand> | ||
| <PowerShellCommand Condition="'$(OS)' != 'Windows_NT'">pwsh</PowerShellCommand> | ||
| <PowerShellCommand> | ||
| $(PowerShellCommand) | ||
| dotnet pwsh | ||
|
mdaigle marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For dotnet commands, our entry point to them has been build(2).proj, and in those files, we have a way to override the path to dotnet. With this change, the path to dotnet can't be overridden. Whether that's acceptable or not is up for discussion, but we already have pipeline mechanisms that use the dotnet override for x86 behavior.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see what you mean, but this step isn't architecture sensitive. Whatever dotnet version is on the path works just fine. |
||
| -NonInteractive | ||
| -ExecutionPolicy Unrestricted | ||
| -Command "$(RepoRoot)tools\intellisense\TrimDocs.ps1 -inputFile '$(DocumentationFile)' -outputFile '$(DocumentationFile)'" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.