POC: DotAiChat #35226
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,70 @@ | ||
| { | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "name": "Launch dotCMS UI (Dev Server)", | ||
| "type": "node", | ||
| "request": "launch", | ||
| "cwd": "${workspaceFolder}", | ||
| "runtimeExecutable": "yarn", | ||
| "runtimeArgs": ["nx", "serve", "dotcms-ui"], | ||
| "console": "integratedTerminal", | ||
| "internalConsoleOptions": "neverOpen", | ||
| "serverReadyAction": { | ||
| "pattern": "Local:.*?(https?://[^\\s]+)", | ||
| "uriFormat": "%s", | ||
| "action": "openExternally" | ||
| } | ||
| }, | ||
| { | ||
| "name": "Debug dotCMS UI in Chrome", | ||
| "type": "chrome", | ||
| "request": "launch", | ||
| "url": "http://localhost:4200", | ||
| "webRoot": "${workspaceFolder}", | ||
| "sourceMapPathOverrides": { | ||
| "webpack:/*": "${webRoot}/*", | ||
| "/./*": "${webRoot}/*", | ||
| "/src/*": "${webRoot}/*", | ||
| "/*": "*", | ||
| "/./~/*": "${webRoot}/node_modules/*" | ||
| } | ||
| }, | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Debug api-dot-ai-chat with Nx", | ||
| "runtimeExecutable": "yarn", | ||
| "runtimeArgs": ["nx", "serve", "api-dot-ai-chat"], | ||
| "env": { | ||
| "NODE_OPTIONS": "--inspect=9229" | ||
| }, | ||
| "console": "integratedTerminal", | ||
| "internalConsoleOptions": "neverOpen", | ||
| "skipFiles": ["<node_internals>/**"], | ||
| "sourceMaps": true, | ||
| "outFiles": [ | ||
| "${workspaceFolder}/api-dot-ai-chat/dist/**/*.(m|c|)js", | ||
| "!**/node_modules/**" | ||
| ] | ||
| }, | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Debug api-dot-ai-chat with Nx", | ||
| "runtimeExecutable": "yarn", | ||
| "runtimeArgs": ["nx", "serve", "api-dot-ai-chat"], | ||
| "env": { | ||
| "NODE_OPTIONS": "--inspect=9230" | ||
| }, | ||
| "console": "integratedTerminal", | ||
| "internalConsoleOptions": "neverOpen", | ||
| "skipFiles": ["<node_internals>/**"], | ||
| "sourceMaps": true, | ||
| "outFiles": [ | ||
| "${workspaceFolder}/apps/api-dot-ai-chat/dist/**/*.(m|c|)js", | ||
| "!**/node_modules/**" | ||
| ] | ||
| } | ||
|
There was a problem hiding this comment. Duplicate launch configs with same name, one wrongLow Severity There are two identical "Debug api-dot-ai-chat with Nx" configurations in   Reviewed by Cursor Bugbot for commit d6f7fc7. Configure here. |
||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "extends": ["../../.eslintrc.base.json"], | ||
| "ignorePatterns": ["!**/*"], | ||
| "overrides": [ | ||
| { | ||
| "files": ["*.ts", "*.tsx", "*.js", "*.jsx"], | ||
| "rules": {} | ||
| }, | ||
| { | ||
| "files": ["*.ts", "*.tsx"], | ||
| "rules": {} | ||
| }, | ||
| { | ||
| "files": ["*.js", "*.jsx"], | ||
| "rules": {} | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| export default { | ||
| displayName: 'api-dot-ai-chat-e2e', | ||
| preset: '../../jest.preset.js', | ||
| globalSetup: '<rootDir>/src/support/global-setup.ts', | ||
| globalTeardown: '<rootDir>/src/support/global-teardown.ts', | ||
| setupFiles: ['<rootDir>/src/support/test-setup.ts'], | ||
| testEnvironment: 'node', | ||
| transform: { | ||
| '^.+\\.[tj]s$': [ | ||
| 'ts-jest', | ||
| { | ||
| tsconfig: '<rootDir>/tsconfig.spec.json' | ||
| } | ||
| ] | ||
| }, | ||
| moduleFileExtensions: ['ts', 'js', 'html'], | ||
| coverageDirectory: '../../coverage/api-dot-ai-chat-e2e' | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "name": "api-dot-ai-chat-e2e", | ||
| "$schema": "../../node_modules/nx/schemas/project-schema.json", | ||
| "projectType": "application", | ||
| "implicitDependencies": ["api-dot-ai-chat"], | ||
| "targets": { | ||
| "e2e": { | ||
| "executor": "@nx/jest:jest", | ||
| "outputs": ["{workspaceRoot}/coverage/{e2eProjectRoot}"], | ||
| "options": { | ||
| "jestConfig": "apps/api-dot-ai-chat-e2e/jest.config.cts", | ||
| "passWithNoTests": true | ||
| }, | ||
| "dependsOn": ["api-dot-ai-chat:build", "api-dot-ai-chat:serve"] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,10 @@ | ||||||||||||||||||||||||||||||||||||||
| import axios from 'axios'; | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| describe('GET /', () => { | ||||||||||||||||||||||||||||||||||||||
| it('should return a message', async () => { | ||||||||||||||||||||||||||||||||||||||
| const res = await axios.get(`/`); | ||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||
| expect(res.status).toBe(200); | ||||||||||||||||||||||||||||||||||||||
| expect(res.data).toEqual({ message: 'Hello API' }); | ||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+3
to
+8
There was a problem hiding this comment. The e2e test expects GET / to return { message: 'Hello API' }, but api-dot-ai-chat currently only defines POST /dotaichat/chat. Either add a GET / (or /health) route in the API app or update the test to hit an actual endpoint.
Suggested change
|
||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||
|
There was a problem hiding this comment. E2E spec tests route that doesn't existMedium Severity The Reviewed by Cursor Bugbot for commit d6f7fc7. Configure here. |
||||||||||||||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||
| import { waitForPortOpen } from '@nx/node/utils'; | ||||||
|
|
||||||
| /* eslint-disable */ | ||||||
| var __TEARDOWN_MESSAGE__: string; | ||||||
|
|
||||||
| module.exports = async function () { | ||||||
| // Start services that that the app needs to run (e.g. database, docker-compose, etc.). | ||||||
| console.log('\nSetting up...\n'); | ||||||
|
|
||||||
| const host = process.env.HOST ?? 'localhost'; | ||||||
| const port = process.env.PORT ? Number(process.env.PORT) : 3000; | ||||||
|
There was a problem hiding this comment. api-dot-ai-chat listens on PORT (default 3333), but the e2e harness defaults to port 3000 for waitForPortOpen. This will cause setup to hang/fail unless PORT is explicitly aligned. Update the defaults (or set PORT for the serve target) so the API and e2e agree on the same port.
Suggested change
There was a problem hiding this comment. E2E default port doesn't match server defaultMedium Severity The e2e test setup ( Reviewed by Cursor Bugbot for commit d6f7fc7. Configure here. |
||||||
| await waitForPortOpen(port, { host }); | ||||||
|
|
||||||
| // Hint: Use `globalThis` to pass variables to global teardown. | ||||||
| globalThis.__TEARDOWN_MESSAGE__ = '\nTearing down...\n'; | ||||||
| }; | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { killPort } from '@nx/node/utils'; | ||
| /* eslint-disable */ | ||
|
|
||
| module.exports = async function () { | ||
| // Put clean up logic here (e.g. stopping services, docker-compose, etc.). | ||
| // Hint: `globalThis` is shared between setup and teardown. | ||
| const port = process.env.PORT ? Number(process.env.PORT) : 3000; | ||
| await killPort(port); | ||
| console.log(globalThis.__TEARDOWN_MESSAGE__); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| /* eslint-disable */ | ||
| import axios from 'axios'; | ||
|
|
||
| module.exports = async function () { | ||
| // Configure axios for tests to use. | ||
| const host = process.env.HOST ?? 'localhost'; | ||
| const port = process.env.PORT ?? '3000'; | ||
| axios.defaults.baseURL = `http://${host}:${port}`; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "extends": "../../tsconfig.base.json", | ||
| "files": [], | ||
| "include": [], | ||
| "references": [ | ||
| { | ||
| "path": "./tsconfig.spec.json" | ||
| } | ||
| ], | ||
| "compilerOptions": { | ||
| "esModuleInterop": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "../../dist/out-tsc", | ||
| "module": "commonjs", | ||
| "types": ["jest", "node"] | ||
| }, | ||
| "include": ["jest.config.ts", "src/**/*.ts"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "extends": ["../../.eslintrc.base.json"], | ||
| "ignorePatterns": ["!**/*"], | ||
| "overrides": [ | ||
| { | ||
| "files": ["*.ts", "*.tsx", "*.js", "*.jsx"], | ||
| "rules": {} | ||
| }, | ||
| { | ||
| "files": ["*.ts", "*.tsx"], | ||
| "rules": {} | ||
| }, | ||
| { | ||
| "files": ["*.js", "*.jsx"], | ||
| "rules": {} | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| module.exports = { | ||
| displayName: 'api-dot-ai-chat', | ||
| preset: '../../jest.preset.js', | ||
| testEnvironment: 'node', | ||
| transform: { | ||
| '^.+\\.[tj]s$': ['ts-jest', { tsconfig: '<rootDir>/tsconfig.spec.json' }] | ||
| }, | ||
| moduleFileExtensions: ['ts', 'js', 'html'], | ||
| coverageDirectory: '../../coverage/apps/api-dot-ai-chat' | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| "name": "api-dot-ai-chat", | ||
| "$schema": "../../node_modules/nx/schemas/project-schema.json", | ||
| "sourceRoot": "apps/api-dot-ai-chat/src", | ||
| "projectType": "application", | ||
| "tags": [], | ||
| "targets": { | ||
| "prune-lockfile": { | ||
| "dependsOn": ["build"], | ||
| "cache": true, | ||
| "executor": "@nx/js:prune-lockfile", | ||
| "outputs": [ | ||
| "{workspaceRoot}/dist/apps/api-dot-ai-chat/package.json", | ||
| "{workspaceRoot}/dist/apps/api-dot-ai-chat/yarn.lock" | ||
| ], | ||
| "options": { | ||
| "buildTarget": "build" | ||
| } | ||
| }, | ||
| "copy-workspace-modules": { | ||
| "dependsOn": ["build"], | ||
| "cache": true, | ||
| "outputs": ["{workspaceRoot}/dist/apps/api-dot-ai-chat/workspace_modules"], | ||
| "executor": "@nx/js:copy-workspace-modules", | ||
| "options": { | ||
| "buildTarget": "build" | ||
| } | ||
| }, | ||
| "prune": { | ||
| "dependsOn": ["prune-lockfile", "copy-workspace-modules"], | ||
| "executor": "nx:noop" | ||
| }, | ||
| "serve": { | ||
| "continuous": true, | ||
| "executor": "@nx/js:node", | ||
| "defaultConfiguration": "development", | ||
| "dependsOn": ["build"], | ||
| "options": { | ||
| "buildTarget": "api-dot-ai-chat:build", | ||
| "runBuildTargetDependencies": false | ||
| }, | ||
| "configurations": { | ||
| "development": { | ||
| "buildTarget": "api-dot-ai-chat:build:development" | ||
| }, | ||
| "production": { | ||
| "buildTarget": "api-dot-ai-chat:build:production" | ||
| } | ||
| } | ||
| }, | ||
| "test": { | ||
| "executor": "@nx/jest:jest", | ||
| "outputs": ["{workspaceRoot}/coverage/{projectRoot}"], | ||
| "options": { | ||
| "jestConfig": "apps/api-dot-ai-chat/jest.config.cts", | ||
| "passWithNoTests": true | ||
| } | ||
| } | ||
| } | ||
| } |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { HashbrownOpenAI } from '@hashbrownai/openai'; | ||
| import express from 'express'; | ||
|
|
||
| const apiKey = process.env['OPENAI_API_KEY']; | ||
|
|
||
| if (!apiKey) { | ||
| throw new Error('OPENAI_API_KEY is not set'); | ||
| } | ||
|
|
||
| const app = express(); | ||
|
|
||
| app.use(express.json()); | ||
| app.use((req, res, next) => { | ||
| res.header('Access-Control-Allow-Origin', '*'); | ||
| res.header('Access-Control-Allow-Headers', 'Content-Type, Authorization'); | ||
| res.header('Access-Control-Allow-Methods', 'GET,POST,PUT,PATCH,DELETE,OPTIONS'); | ||
|
|
||
|
Comment on lines
+13
to
+17
There was a problem hiding this comment. CORS is configured to allow any origin (*) while this service proxies requests using the server-side OPENAI_API_KEY. If this app is ever run beyond a strictly local setup, it becomes an unauthenticated OpenAI proxy that can be abused. Please restrict allowed origins (at least to localhost) and/or require authentication for /dotaichat/chat. |
||
| if (req.method === 'OPTIONS') { | ||
| res.sendStatus(204); | ||
| return; | ||
| } | ||
|
|
||
| next(); | ||
| }); | ||
|
|
||
| app.post('/dotaichat/chat', async (req, res) => { | ||
| const stream = HashbrownOpenAI.stream.text({ | ||
| apiKey, | ||
| request: req.body | ||
| }); | ||
|
|
||
| res.header('Content-Type', 'application/octet-stream'); | ||
|
|
||
| for await (const chunk of stream) { | ||
| res.write(chunk); | ||
| } | ||
|
|
||
| res.end(); | ||
| }); | ||
|
Comment on lines
+26
to
+39
There was a problem hiding this comment. There is no GET endpoint (e.g., / or /health) implemented, but the repository’s e2e scaffold is testing GET /. Adding a lightweight health/root route (and keeping it aligned with tests) will make local/dev validation much clearer. |
||
|
|
||
| const port = process.env.PORT || 3333; | ||
| const server = app.listen(port, () => { | ||
| // eslint-disable-next-line no-console | ||
| console.log(`Listening at http://localhost:${port}/dotaichat`); | ||
| }); | ||
| server.on('error', console.error); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "../../dist/out-tsc", | ||
| "module": "commonjs", | ||
| "moduleResolution": "node10", | ||
| "types": ["node", "express"] | ||
| }, | ||
| "include": ["src/**/*.ts"], | ||
| "exclude": ["jest.config.ts", "jest.config.cts", "src/**/*.spec.ts", "src/**/*.test.ts"] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two launch configurations with the same name ("Debug api-dot-ai-chat with Nx"), and the first one’s outFiles path points to
${workspaceFolder}/api-dot-ai-chat/dist/...which doesn’t match the app location underapps/api-dot-ai-chat. This can make VS Code debugging pick the wrong config and fail to map sources.