Add Automatic Module Names for Java packages#12114
Conversation
This allows using XGBoost in Modular (Java 9+) projects Fixes #11792
|
cc @wbo4958 |
|
Thx @carl-mastrangelo, Can you also add it support for xgboost4j-spark-gpu module? |
|
@wbo4958 Done. Just a heads up, I manually tested the other three Jars, but since the Spark GPU is using shading, it's not exactly clear what the module would be, or if it should be shaded as well. Also, since I don't have an Nvidia card, I wasn't able to run the tests. |
| <configuration> | ||
| <archive> | ||
| <manifestEntries> | ||
| <Automatic-Module-Name>ml.dmlc.xgboost4j.sparkgpu</Automatic-Module-Name> |
There was a problem hiding this comment.
how about "ml.dmlc.xgboost4j.spark" ?
There was a problem hiding this comment.
I'm afraid that would conflict with the other spark module. My understanding is they need to be unique.
There was a problem hiding this comment.
how about ml.dmlc.xgboost4j.spark.gpu ?
There was a problem hiding this comment.
Works for me. PTAL.
|
@wbo4958 Any other feedback? |
|
LGTM. Thx for your PR. |
3 participants
This allows using XGBoost in Modular (Java 9+) projects
Fixes #11792