Skip to content

#1102: add MSI signing process to release workflow using SignPath#1899

Merged
hohwille merged 4 commits into
devonfw:mainfrom
ducminh02:1102-sign-msi-installer-release-build
May 22, 2026
Merged

#1102: add MSI signing process to release workflow using SignPath#1899
hohwille merged 4 commits into
devonfw:mainfrom
ducminh02:1102-sign-msi-installer-release-build

Conversation

@ducminh02
Copy link
Copy Markdown
Contributor

@ducminh02 ducminh02 commented May 6, 2026

This PR fixes #1102

Implemented changes:

  • Add release signing workflow

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 6, 2026
@ducminh02 ducminh02 self-assigned this May 6, 2026
@ducminh02 ducminh02 moved this from 🆕 New to 👀 In review in IDEasy board May 6, 2026
@ducminh02 ducminh02 changed the title feat: add MSI signing process to release workflow using SignPath #1102 add MSI signing process to release workflow using SignPath May 6, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 6, 2026

Coverage Report for CI Build 26281541231

Coverage decreased (-0.02%) to 71.09%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/version/VersionSegment.java 1 90.03%

Coverage Stats

Coverage Status
Relevant Lines: 15563
Covered Lines: 11538
Line Coverage: 74.14%
Relevant Branches: 6952
Covered Branches: 4468
Branch Coverage: 64.27%
Branches in Coverage %: Yes
Coverage Strength: 3.14 hits per line

💛 - Coveralls

Comment thread .github/workflows/release.yml Outdated
@hohwille hohwille added this to the release:2026.05.001 milestone May 22, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ducminh02 thanks again. Ready for merge now. 👍

@hohwille hohwille merged commit 2a8d4e3 into devonfw:main May 22, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board May 22, 2026
@hohwille hohwille changed the title #1102 add MSI signing process to release workflow using SignPath #1102: add MSI signing process to release workflow using SignPath May 22, 2026
@hohwille
Copy link
Copy Markdown
Member

This can only be retested by running the release workflow.
I will do that with the release.
If it does not work, I will reopen the issue or create a new bug ticket.
Therefore I already set the QA label now since it is impossible to do a release without testing it.

@hohwille hohwille added release related to release commandlet and releases of IDEasy workflow GitHub actions (CI,CD,update urls/CVEs) QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. release related to release commandlet and releases of IDEasy workflow GitHub actions (CI,CD,update urls/CVEs)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

IDEasy MSI installer not working (unsigned)

3 participants