#1849: Add support for VSCodium#1888
Conversation
Coverage Report for CI Build 26298418261Warning No base build found for commit Coverage: 71.079%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
laert-ll
force-pushed
the
feature/1849-support-vscodium
branch
from
7561315 to
24015b6
Compare
|
I think we should add VSCodium to the table of tools in LICENSE.asciidoc as it has a different license (see https://github.com/VSCodium/vscodium/blob/master/LICENSE). Also we need to add the tool to both Help.properties and Help_de.properties |
|
Also i think we are missing tests for the VSCodium. Maybe something like https://github.com/devonfw/IDEasy/blob/main/cli/src/test/java/com/devonfw/tools/ide/tool/vscode/VscodeTest.java |
laert-ll
force-pushed
the
feature/1849-support-vscodium
branch
from
ccf6c23 to
13862e9
Compare
laert-ll
force-pushed
the
feature/1849-support-vscodium
branch
from
506e6ee to
d62e97c
Compare
laert-ll
force-pushed
the
feature/1849-support-vscodium
branch
2 times, most recently
from
bf094ac to
00ffa58
Compare
| }, suppressLevel); | ||
| if (isVscodium && !this.vscodiumUnavailablePlugins.isEmpty()) { | ||
| LOG.warn("{} plugin(s) could not be installed on VSCodium due to not being available on open-vsx or other errors:\n - {}\n" | ||
| + "For full plugin support, set VSCODE_EDITION=vscode to use Microsoft's distribution.\n" | ||
| + "For more detailed information on why plugins failed to install, check the IDEasy logfile at $IDE_ROOT/_ide/logs/.", | ||
| this.vscodiumUnavailablePlugins.size(), | ||
| String.join("\n - ", this.vscodiumUnavailablePlugins)); | ||
| } |
There was a problem hiding this comment.
Issue: VSCodium does not support all the plugins that VSCode does.
I figured it would be better to suppress the very large red error messages that normally come when not being able to install the plugins, since it gives the impression that this is unexpected behavior. This is a temporary workaround for potentially a future story where we would have a separate list of plugins that are compatible with VSCodium.
Fix rebase conflict
laert-ll
force-pushed
the
feature/1849-support-vscodium
branch
from
911a75d to
1fcb597
Compare
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@laert-ll thanks for your PR to support and integrate VSCodium. This looks pretty much complete with URLUpdater, Commandlet, Tests, Help, etc. 👍
Great that you also added special support for incompatible plugins.
I hope the statefulness (adding this List<String> as field vscodiumUnavailablePlugins) will not cause problems in the future but for now it should work fine and I could not find any idea how to solve this stateless.
| /** | ||
| * {@link GithubUrlTagUpdater} for the "vscodium" edition of vscode (<a href="https://vscodium.com/">VSCodium</a>). | ||
| */ | ||
| public class VsCodiumUrlUpdater extends GithubUrlTagUpdater { |
There was a problem hiding this comment.
There are GitHub releases available for VSCodium:
https://github.com/VSCodium/vscodium/releases/
As we already discussed in such case GithubUrlReleaseUpdater should be preferred.
See also #1949
4 participants
This PR fixes #1849
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal