fix(module): add idempotency for usb cleanup in virtualization-dra#2216
Open
fix(module): add idempotency for usb cleanup in virtualization-dra#2216
Conversation
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add idempotency to USB device cleanup in the virtualization-dra component.
Changes:
store.go: Add early return if claim is already unprepared. UsehasCountcheck to handle missing or zero counts gracefully. Replaceif/elsewithswitchfor clearer count handling (0, 1, >1).usbgateway.go: MakeDetachidempotent — log and skip if device is already detached instead of failing. Always clean up the attach record after detach attempt.attach_record.go: AddRemoveEntryByDeviceNamemethod to remove a specific device entry from the attach record. ExtractstoreLockedhelper to avoid code duplication.Why do we need it, and what problem does it solve?
When
UnprepareResourcesis called multiple times for the same claim (e.g., during retries or race conditions), the cleanup logic could fail or produce incorrect results:usbipAllocatedDevicesCountmap could be accessed for non-existent keys, leading to incorrect behavior.After this fix, repeated cleanup calls are safe and produce consistent results.
What is the expected result?
UnprepareResourcesfor a claim that has USB devices attached via USBGateway.UnprepareResourcesagain for the same claim.Checklist
Changelog entries