[deckhouse-cli] Skip database pulling when they don't exist#327
Draft
Glitchy-Sheep wants to merge 3 commits intomainfrom
Draft
[deckhouse-cli] Skip database pulling when they don't exist#327Glitchy-Sheep wants to merge 3 commits intomainfrom
Glitchy-Sheep wants to merge 3 commits intomainfrom
Conversation
- Editions without security databases (CE, BE, SE) produced contradictory logs: "Skipping pull" followed by "All required databases are pulled" and an empty security.tar - securityDatabasesAvailable now returns (bool, error) so the caller can distinguish "images exist" from "images not found" and skip the entire pull early Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
Glitchy-Sheep
force-pushed
the
fix/ambiguous-security-images-logs
branch
from
c906111 to
8db4601
Compare
Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
Signed-off-by: Roman Berezkin <roman.berezkin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
d8 mirror pullfor editions without security databases (CE, BE, SE), the logs are contradictory:security.taris created with no actual data.The user sees "skipping" and "all pulled" at the same time and cannot understand what actually happened.
Root cause
validateSecurityAccessdetects missing security images in the registry, logs "Skipping", but returnsnil.err == nil.security.tar.Fix
Rename
validateSecurityAccesswithsecurityDatabasesAvailablewhich returns(bool, error).When
!available, the entire pull is skipped - no unnecessary requests, no contradictory logs, no emptysecurity.tar.Before (Pulling non existing security)
After (Pulling non existing security)
After - (Pulling existing security)