Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the test command that used to run tests after the generation by the code generation with the compile command. As the process of generation is automated now and all the tests run on the PR (in a standard test environment), it is no longer necessary to run the tests in local environments, which may lead to inconsistent results depending on machine setup and configurations.
Why
This makes it easier for the person debugging the failed automated workflow to identify why the update-sdk process failed - he can directly see the failing tests in the CI.
What changed
The post generate command no longer runs tests locally.
Interface changes
N/A
Behavioral changes
N/A
Internal changes
This PR replaces the test command that used to run tests after the generation by the code generation with the compile command.
How is this tested?
N/A
NO_CHANGELOG=true