Skip to content

fix: fix miss makezero bug#334

Open
alingse wants to merge 1 commit intocube2222:mainfrom
alingse-forks:fix-makezero-bug
Open

fix: fix miss makezero bug#334
alingse wants to merge 1 commit intocube2222:mainfrom
alingse-forks:fix-makezero-bug

Conversation

@alingse
Copy link
Copy Markdown

@alingse alingse commented May 26, 2024

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242658341/job/25425755939

====================================================================================================
append to slice `newPending` with non-zero initialized length at https://github.com/cube2222/octosql/blob/main/outputs/stream/internally_consistent_output_stream_wrapper.go#L2[9](https://github.com/alingse/go-linter-runner/actions/runs/9242658341/job/25425755939#step:4:10):18
====================================================================================================

but the newPending pending convert is complex to understand, maybe this was a feature ?

Signed-off-by: alingse <alingse@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant