Skip to content

Added appropriate error for blank field name heading in record imports (D1099)#594

Merged
abeverley merged 5 commits intoctrlo:devfrom
pwlodarski-ctrlo:empty-import-heading-patch
Apr 15, 2026
Merged

Added appropriate error for blank field name heading in record imports (D1099)#594
abeverley merged 5 commits intoctrlo:devfrom
pwlodarski-ctrlo:empty-import-heading-patch

Conversation

@pawelwlod
Copy link
Copy Markdown

Throw an error to the user if a field name heading is blank, alongside the column number in the CSV file being imported.

@pawelwlod pawelwlod changed the title Added appropriate error for blank field name heading in record imports Added appropriate error for blank field name heading in record imports (D1099) Dec 17, 2025
Comment thread lib/GADS/Import.pm Outdated
@abeverley
Copy link
Copy Markdown
Contributor

Thanks Pawel, this is good. I realise the ticket says that this will be a manual test, but it would be relatively easy to add an automated test. Maybe you can take a look at that? A new section in t/014_import.t, creating a new GADS::Import object with appropriate CSV content and wrapping in a try {} block should suffice.

@pwlodarski-ctrlo
Copy link
Copy Markdown

Thanks Pawel, this is good. I realise the ticket says that this will be a manual test, but it would be relatively easy to add an automated test. Maybe you can take a look at that? A new section in t/014_import.t, creating a new GADS::Import object with appropriate CSV content and wrapping in a try {} block should suffice.

This has been actioned and committed to this PR.

@abeverley abeverley merged commit 6c91fe7 into ctrlo:dev Apr 15, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants